You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/06/08 07:06:00 UTC
[GitHub] [helix] pkuwm opened a new issue #1071: Znode write size limit in zkclient is not consistent with the one in znrecord serializers
pkuwm opened a new issue #1071:
URL: https://github.com/apache/helix/issues/1071
There is configurable write size limit for znrecord serializer. But there is also a data size limit check in raw zkclient:
```
private void checkDataSizeLimit(byte[] data) {
if (data != null && data.length > ZNRecord.SIZE_LIMIT) {
```
If configurable write size limit for znrecord serializer is different from the default size 1 MB, especially it is set to larger than 1 MB, writing won't work because it would be blocked by this default size check in zkclient.
We need to fix it. A good idea is to make both consistently same. But the system property `zk.serializer.znrecord.write.size.limit.bytes` is for a **ZNRecord serializer**, not sure if it is fine to put it at ZkClient level, as it will apply to all other serializers, as well. We may discuss this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm closed issue #1071: Znode write size limit in zkclient is not consistent with the one in znrecord serializers
Posted by GitBox <gi...@apache.org>.
pkuwm closed issue #1071:
URL: https://github.com/apache/helix/issues/1071
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org