You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/02/26 03:00:56 UTC
Review Request 31456: Only fetch host attributes once per preemption
round.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31456/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Bugs: AURORA-1153
https://issues.apache.org/jira/browse/AURORA-1153
Repository: aurora
Description
-------
A small, but cheap performance improvement when the preemptor is engaged.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImpl.java 42af883721e4e5c0ae23ff65a5fb7dc285e48faa
Diff: https://reviews.apache.org/r/31456/diff/
Testing
-------
Before this diff:
```
o.a.a.b.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.runBenchmark avgt 100 5788175.295 ± 47410.511 ns/op
o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.runBenchmark avgt 100 5046038.818 ± 38636.961 ns/op
o.a.a.b.SchedulingBenchmarks.PreemptorFallbackForLargeClusterBenchmark.runBenchmark avgt 100 64323073.493 ± 644053.437 ns/op
```
After this diff:
```
o.a.a.b.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.runBenchmark avgt 100 5783859.480 ± 37291.662 ns/op
o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.runBenchmark avgt 100 5259022.679 ± 30276.902 ns/op
o.a.a.b.SchedulingBenchmarks.PreemptorFallbackForLargeClusterBenchmark.runBenchmark avgt 100 58171450.071 ± 638305.308 ns/op
```
So, about 10% for ~free.
Thanks,
Bill Farner
Re: Review Request 31456: Only fetch host attributes once per
preemption round.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31456/#review74189
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On Feb. 25, 2015, 6 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31456/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2015, 6 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-1153
> https://issues.apache.org/jira/browse/AURORA-1153
>
>
> Repository: aurora
>
>
> Description
> -------
>
> A small, but cheap performance improvement when the preemptor is engaged.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImpl.java 42af883721e4e5c0ae23ff65a5fb7dc285e48faa
>
> Diff: https://reviews.apache.org/r/31456/diff/
>
>
> Testing
> -------
>
> Before this diff:
>
> ```
> o.a.a.b.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.runBenchmark avgt 100 5788175.295 ± 47410.511 ns/op
> o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.runBenchmark avgt 100 5046038.818 ± 38636.961 ns/op
> o.a.a.b.SchedulingBenchmarks.PreemptorFallbackForLargeClusterBenchmark.runBenchmark avgt 100 64323073.493 ± 644053.437 ns/op
> ```
>
> After this diff:
> ```
> o.a.a.b.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.runBenchmark avgt 100 5783859.480 ± 37291.662 ns/op
> o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.runBenchmark avgt 100 5259022.679 ± 30276.902 ns/op
> o.a.a.b.SchedulingBenchmarks.PreemptorFallbackForLargeClusterBenchmark.runBenchmark avgt 100 58171450.071 ± 638305.308 ns/op
> ```
>
> So, about 10% for ~free.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 31456: Only fetch host attributes once per
preemption round.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31456/#review74187
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On Feb. 26, 2015, 2 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31456/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2015, 2 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-1153
> https://issues.apache.org/jira/browse/AURORA-1153
>
>
> Repository: aurora
>
>
> Description
> -------
>
> A small, but cheap performance improvement when the preemptor is engaged.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImpl.java 42af883721e4e5c0ae23ff65a5fb7dc285e48faa
>
> Diff: https://reviews.apache.org/r/31456/diff/
>
>
> Testing
> -------
>
> Before this diff:
>
> ```
> o.a.a.b.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.runBenchmark avgt 100 5788175.295 ± 47410.511 ns/op
> o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.runBenchmark avgt 100 5046038.818 ± 38636.961 ns/op
> o.a.a.b.SchedulingBenchmarks.PreemptorFallbackForLargeClusterBenchmark.runBenchmark avgt 100 64323073.493 ± 644053.437 ns/op
> ```
>
> After this diff:
> ```
> o.a.a.b.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.runBenchmark avgt 100 5783859.480 ± 37291.662 ns/op
> o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.runBenchmark avgt 100 5259022.679 ± 30276.902 ns/op
> o.a.a.b.SchedulingBenchmarks.PreemptorFallbackForLargeClusterBenchmark.runBenchmark avgt 100 58171450.071 ± 638305.308 ns/op
> ```
>
> So, about 10% for ~free.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 31456: Only fetch host attributes once per
preemption round.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31456/#review74198
-----------------------------------------------------------
Master (9442e08) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 26, 2015, 2 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31456/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2015, 2 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-1153
> https://issues.apache.org/jira/browse/AURORA-1153
>
>
> Repository: aurora
>
>
> Description
> -------
>
> A small, but cheap performance improvement when the preemptor is engaged.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImpl.java 42af883721e4e5c0ae23ff65a5fb7dc285e48faa
>
> Diff: https://reviews.apache.org/r/31456/diff/
>
>
> Testing
> -------
>
> Before this diff:
>
> ```
> o.a.a.b.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.runBenchmark avgt 100 5788175.295 ± 47410.511 ns/op
> o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.runBenchmark avgt 100 5046038.818 ± 38636.961 ns/op
> o.a.a.b.SchedulingBenchmarks.PreemptorFallbackForLargeClusterBenchmark.runBenchmark avgt 100 64323073.493 ± 644053.437 ns/op
> ```
>
> After this diff:
> ```
> o.a.a.b.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.runBenchmark avgt 100 5783859.480 ± 37291.662 ns/op
> o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.runBenchmark avgt 100 5259022.679 ± 30276.902 ns/op
> o.a.a.b.SchedulingBenchmarks.PreemptorFallbackForLargeClusterBenchmark.runBenchmark avgt 100 58171450.071 ± 638305.308 ns/op
> ```
>
> So, about 10% for ~free.
>
>
> Thanks,
>
> Bill Farner
>
>