You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/05/16 16:08:18 UTC
[GitHub] [kafka] Moovlin opened a new pull request, #12167: KAFKA-13716 Added the DeleteRecordsCommandTest to test the CLI front end of the D…
Moovlin opened a new pull request, #12167:
URL: https://github.com/apache/kafka/pull/12167
…eleteRecordsCommand.
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
Added a new test for the front end of the DeleteRecordsCommand command line tool.
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [x] Verify design and implementation
- [x] Verify test coverage and CI build status
- [x] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] Moovlin commented on pull request #12167: KAFKA-13716 Added the DeleteRecordsCommandTest to test the CLI front end of the D…
Posted by GitBox <gi...@apache.org>.
Moovlin commented on PR #12167:
URL: https://github.com/apache/kafka/pull/12167#issuecomment-1129000522
@showuon happy to try and help. For my sake since this is the first code contribution I've made, could you help me out by answering some questions?
1. When you say add some test for wrong & good configs, do you mean to remove the particular unit tests and then add it to the `TopicCommandTest.scala` instead? Or are you suggesting that there should be a couple more tests added to cover the usage a bit more completely?
2. In terms of integration testing, that was what I understood this Jira to be originally but upon getting clarification in the Jira I was under the impression that this was only related to the CLI portion of the command and not the functionality. [Link to the comment](https://issues.apache.org/jira/browse/KAFKA-13716?focusedCommentId=17528047&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17528047). So I don't think there is a need for integration testing but I'm happy to be wrong here.
Greatly appreciate the feedback and for helping me work through (what I hope is) my first code contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] Moovlin commented on pull request #12167: KAFKA-13716 Added the DeleteRecordsCommandTest to test the CLI front end of the D…
Posted by GitBox <gi...@apache.org>.
Moovlin commented on PR #12167:
URL: https://github.com/apache/kafka/pull/12167#issuecomment-1134854139
@showuon I've gone ahead and added more tests as suggested. Happy to receive feedback on them! In addition, I opened the following jira as we agreed to to track integration tests: [KAFKA-13931](https://issues.apache.org/jira/browse/KAFKA-13931)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #12167: KAFKA-13716 Added the DeleteRecordsCommandTest to test the CLI front end of the D…
Posted by GitBox <gi...@apache.org>.
showuon commented on PR #12167:
URL: https://github.com/apache/kafka/pull/12167#issuecomment-1131061627
> 1. When you say add some test for wrong & good configs, do you mean to remove the particular unit tests and then add it to the TopicCommandTest.scala instead? Or are you suggesting that there should be a couple more tests added to cover the usage a bit more completely?
I mean add more tests to cover the usage in `DeleteRecordsCommandTest.scala` (and you can refer to TopicCommandTest
> 2. In terms of integration testing, that was what I understood this Jira to be originally but upon getting clarification in the Jira I was under the impression that this was only related to the CLI portion of the command and not the functionality. [Link to the comment](https://issues.apache.org/jira/browse/KAFKA-13716?focusedCommentId=17528047&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17528047). So I don't think there is a need for integration testing but I'm happy to be wrong here.
It's fine we only add unit tests (cli command tests) in this PR. But it'd better if we can add integration tests for it, too. I'm OK if you want to keep this PR scope as unit test only.
Thanks for the contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] Moovlin commented on pull request #12167: KAFKA-13716 Added the DeleteRecordsCommandTest to test the CLI front end of the D…
Posted by GitBox <gi...@apache.org>.
Moovlin commented on PR #12167:
URL: https://github.com/apache/kafka/pull/12167#issuecomment-1145952034
Hey @showuon , just looking to see if you have any input on the last commit I made to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #12167: KAFKA-13716 Added the DeleteRecordsCommandTest to test the CLI front end of the D…
Posted by GitBox <gi...@apache.org>.
showuon commented on PR #12167:
URL: https://github.com/apache/kafka/pull/12167#issuecomment-1132408449
> So I'd like to keep the scope of this PR to unit tests. If you think that makes sense, I'll go ahead and open up an issue for it to make sure we track that outstanding item.
Yes, make sense. Please open up another JIRA issue for it. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] Moovlin commented on pull request #12167: KAFKA-13716 Added the DeleteRecordsCommandTest to test the CLI front end of the D…
Posted by GitBox <gi...@apache.org>.
Moovlin commented on PR #12167:
URL: https://github.com/apache/kafka/pull/12167#issuecomment-1131755255
Thanks for the quick responses. To your first answer, I'm happy to do that and will take a look at the TopciCommandTest for guidance.
To your second answer. Integration tests for this should probably be in a different Jira since the methods in the MockAdminClient are effectively not implemented (if you try to do anything other than delete from the first offset, it throws an UnsupportedOperationException). So I'd like to keep the scope of this PR to unit tests. If you think that makes sense, I'll go ahead and open up an issue for it to make sure we track that outstanding item.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org