You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/07 15:17:11 UTC

[GitHub] [flink] rudikershaw opened a new pull request #17431: [FLINK-24431][kinesis][efo] Stop consumer deregistration when EAGER EFO configured into 1.12.x

rudikershaw opened a new pull request #17431:
URL: https://github.com/apache/flink/pull/17431


   ## What is the purpose of the change
   
   This is a fix being pulled back into 1.12, please see #17417 for the original PR. The following is just the original text from the previous pull request; 
   
   The EFO Kinesis connector will register and de-register stream consumers based on the [configured registration strategy](https://ci.apache.org/projects/flink/flink-docs-release-1.13/docs/connectors/datastream/kinesis/#efo-stream-consumer-registrationderegistration). When EAGER is used, the client (usually job manager) will register the consumer and then the task managers will de-register the consumer when job stops/fails. If the job is configured to restart on fail, then the consumer will not exist and the job will continuously fail over.
   
   After this change the connector will not trigger consumer deregistration in EFO if using the EAGER registration strategy. This will allow EAGER EFO configured connector applications to use restart policies without continuously failing. The documentation is updated accordingly.
   
   ## Brief change log
   
     - *Add dedicated utility function for determining whether consumer deregistration is required.*
     - *Ensure consumer deregistration now only occurs when EFO is configured using the LAZY registration strategy.*
     - *Update the documentation to reflect the changes.* 
   
   
   ## Verifying this change
   
   Parts of this change are already covered by existing tests in `org.apache.flink.streaming.connectors.kinesis.util.StreamConsumerRegistrarUtilTest`. 
   
   This change added tests and can be verified as follows:
     - *Added unit test to verify deregistration criteria i.e. `org.apache.flink.streaming.connectors.kinesis.util.StreamConsumerRegistrarUtilTest#testDeregisterStreamConsumersOnlyDeregistersEFOLazilyInitializedConsumers`*
     - *Manually verified the change by running a Flink application with a fixed delay restart strategy and a FlinkKinesisConsumer with EAGER EFO configured.* 
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **No**
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **No**
     - The serializers: **No**
     - The runtime per-record code paths (performance sensitive): **No**
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: **_Yes_**
     - The S3 file system connector: **No**
   
   ## Documentation
   
     - References to the EAGER EFO deregistration policy have been updated in `datastream/kinesis.md` and `table/kinesis.md`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dannycranmer merged pull request #17431: [FLINK-24431][kinesis][efo] Stop consumer deregistration when EAGER EFO configured into 1.12.x

Posted by GitBox <gi...@apache.org>.

dannycranmer merged pull request #17431:
URL: https://github.com/apache/flink/pull/17431


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #17431: [FLINK-24431][kinesis][efo] Stop consumer deregistration when EAGER EFO configured into 1.12.x

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #17431:
URL: https://github.com/apache/flink/pull/17431#issuecomment-937896727

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit 191eee54006303b07fd453ad6971cbf8a55c4b38 (Thu Oct 07 15:20:32 UTC 2021)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.

Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:

- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #17431: [FLINK-24431][kinesis][efo] Stop consumer deregistration when EAGER EFO configured into 1.12.x

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #17431:
URL: https://github.com/apache/flink/pull/17431#issuecomment-938517957


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "191eee54006303b07fd453ad6971cbf8a55c4b38",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "191eee54006303b07fd453ad6971cbf8a55c4b38",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 191eee54006303b07fd453ad6971cbf8a55c4b38 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #17431: [FLINK-24431][kinesis][efo] Stop consumer deregistration when EAGER EFO configured into 1.12.x

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #17431:
URL: https://github.com/apache/flink/pull/17431#issuecomment-937896727

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit 191eee54006303b07fd453ad6971cbf8a55c4b38 (Thu Oct 07 15:20:32 UTC 2021)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17431: [FLINK-24431][kinesis][efo] Stop consumer deregistration when EAGER EFO configured into 1.12.x

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #17431:
URL: https://github.com/apache/flink/pull/17431#issuecomment-938517957


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "191eee54006303b07fd453ad6971cbf8a55c4b38",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24847",
       "triggerID" : "191eee54006303b07fd453ad6971cbf8a55c4b38",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 191eee54006303b07fd453ad6971cbf8a55c4b38 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24847) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17431: [FLINK-24431][kinesis][efo] Stop consumer deregistration when EAGER EFO configured into 1.12.x

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #17431:
URL: https://github.com/apache/flink/pull/17431#issuecomment-938517957


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "191eee54006303b07fd453ad6971cbf8a55c4b38",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24847",
       "triggerID" : "191eee54006303b07fd453ad6971cbf8a55c4b38",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 191eee54006303b07fd453ad6971cbf8a55c4b38 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24847) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org