You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Ian Eure (JIRA)" <ji...@apache.org> on 2010/01/14 01:00:56 UTC
[jira] Created: (THRIFT-673) Generated Python code has whitespace
issues
Generated Python code has whitespace issues
-------------------------------------------
Key: THRIFT-673
URL: https://issues.apache.org/jira/browse/THRIFT-673
Project: Thrift
Issue Type: Improvement
Components: Compiler (Python)
Affects Versions: 0.2
Environment: Irrelevant.
Reporter: Ian Eure
Priority: Minor
Fix For: 0.2
The Python code generator produces code with a number of whitespace issues:
- Trailing whitespace at the end of lines.
- Multiple blank newlines at the end of files.
Both of these issues cause problems if the code is used in a Git repository with `git diff --check' in a hook. The attached patch corrects the code generation to address these issues.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-673) Generated Python code has whitespace
issues
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-673:
---------------------------------
Fix Version/s: 0.4
(was: 0.2)
> Generated Python code has whitespace issues
> -------------------------------------------
>
> Key: THRIFT-673
> URL: https://issues.apache.org/jira/browse/THRIFT-673
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Python)
> Affects Versions: 0.2
> Environment: Irrelevant.
> Reporter: Ian Eure
> Priority: Minor
> Fix For: 0.4
>
> Attachments: patch-src-whitespace.diff
>
>
> The Python code generator produces code with a number of whitespace issues:
> - Trailing whitespace at the end of lines.
> - Multiple blank newlines at the end of files.
> Both of these issues cause problems if the code is used in a Git repository with `git diff --check' in a hook. The attached patch corrects the code generation to address these issues.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-673) Generated Python code has whitespace
issues
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-673.
--------------------------------
Assignee: Ian Eure
Fix Version/s: 0.5
Resolution: Fixed
I just committed this.
> Generated Python code has whitespace issues
> -------------------------------------------
>
> Key: THRIFT-673
> URL: https://issues.apache.org/jira/browse/THRIFT-673
> Project: Thrift
> Issue Type: Improvement
> Components: Python - Compiler
> Affects Versions: 0.2
> Environment: Irrelevant.
> Reporter: Ian Eure
> Assignee: Ian Eure
> Priority: Minor
> Fix For: 0.5
>
> Attachments: patch-src-whitespace.diff
>
>
> The Python code generator produces code with a number of whitespace issues:
> - Trailing whitespace at the end of lines.
> - Multiple blank newlines at the end of files.
> Both of these issues cause problems if the code is used in a Git repository with `git diff --check' in a hook. The attached patch corrects the code generation to address these issues.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-673) Generated Python code has whitespace
issues
Posted by "Ian Eure (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ian Eure updated THRIFT-673:
----------------------------
Attachment: patch-src-whitespace.diff
> Generated Python code has whitespace issues
> -------------------------------------------
>
> Key: THRIFT-673
> URL: https://issues.apache.org/jira/browse/THRIFT-673
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Python)
> Affects Versions: 0.2
> Environment: Irrelevant.
> Reporter: Ian Eure
> Priority: Minor
> Fix For: 0.2
>
> Attachments: patch-src-whitespace.diff
>
>
> The Python code generator produces code with a number of whitespace issues:
> - Trailing whitespace at the end of lines.
> - Multiple blank newlines at the end of files.
> Both of these issues cause problems if the code is used in a Git repository with `git diff --check' in a hook. The attached patch corrects the code generation to address these issues.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-673) Generated Python code has whitespace
issues
Posted by "Ian Eure (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ian Eure updated THRIFT-673:
----------------------------
Attachment: patch-src-whitespace.diff
Updated patch which catches one more case of trailing whitespace.
> Generated Python code has whitespace issues
> -------------------------------------------
>
> Key: THRIFT-673
> URL: https://issues.apache.org/jira/browse/THRIFT-673
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Python)
> Affects Versions: 0.2
> Environment: Irrelevant.
> Reporter: Ian Eure
> Priority: Minor
> Fix For: 0.2
>
> Attachments: patch-src-whitespace.diff
>
>
> The Python code generator produces code with a number of whitespace issues:
> - Trailing whitespace at the end of lines.
> - Multiple blank newlines at the end of files.
> Both of these issues cause problems if the code is used in a Git repository with `git diff --check' in a hook. The attached patch corrects the code generation to address these issues.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-673) Generated Python code has whitespace
issues
Posted by "Ian Eure (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ian Eure updated THRIFT-673:
----------------------------
Attachment: (was: patch-src-whitespace.diff)
> Generated Python code has whitespace issues
> -------------------------------------------
>
> Key: THRIFT-673
> URL: https://issues.apache.org/jira/browse/THRIFT-673
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Python)
> Affects Versions: 0.2
> Environment: Irrelevant.
> Reporter: Ian Eure
> Priority: Minor
> Fix For: 0.2
>
> Attachments: patch-src-whitespace.diff
>
>
> The Python code generator produces code with a number of whitespace issues:
> - Trailing whitespace at the end of lines.
> - Multiple blank newlines at the end of files.
> Both of these issues cause problems if the code is used in a Git repository with `git diff --check' in a hook. The attached patch corrects the code generation to address these issues.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.