[GitHub] [geode-native] moleske commented on a change in pull request #642: GEODE-8457: Fix crash when IO_error and single-hop=false

[GitBox <gi...@apache.org>]

moleske commented on a change in pull request #642:
URL: https://github.com/apache/geode-native/pull/642#discussion_r477581852



##########
File path: cppcache/src/ThinClientPoolDM.cpp
##########
@@ -1428,10 +1428,12 @@ GfErrType ThinClientPoolDM::sendSyncRequest(
           }
           excludeServers.insert(ServerLocation(ep->name()));
           if (error == GF_IOERR) {
-            auto sl = std::make_shared<BucketServerLocation>(ep->name());
-            LOGINFO("Removing bucketServerLocation %s due to GF_IOERR",
-                    sl->toString().c_str());
-            m_clientMetadataService->removeBucketServerLocation(sl);
+            if (m_clientMetadataService != nullptr) {

Review comment:
       When I see an `if` statement, I usually think there's a possible test case.  One for when the statement is `true`, and one for `false`.  Is it possible to write a test for this and the below `if` statements?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org