You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Zhijie Shen (JIRA)" <ji...@apache.org> on 2014/11/01 22:30:34 UTC
[jira] [Commented] (YARN-2752)
TestContainerExecutor.testRunCommandNoPriority fails in branch-2
[ https://issues.apache.org/jira/browse/YARN-2752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14193494#comment-14193494 ]
Zhijie Shen commented on YARN-2752:
-----------------------------------
The fix makes sense. Currently the branch-2 code will always add "nice -n" argument whether the priority is using the default 0 or a user customized value.
One suggestion: maybe it's better to apply the diff between trunk and branch-2 here. It prevents the merge failure if we modify this code on the trunk, and cherry pick it to branch-2 in the future.
> TestContainerExecutor.testRunCommandNoPriority fails in branch-2
> ----------------------------------------------------------------
>
> Key: YARN-2752
> URL: https://issues.apache.org/jira/browse/YARN-2752
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Xuan Gong
> Assignee: Xuan Gong
> Attachments: YARN-2752.1-branch-2.patch
>
>
> TestContainerExecutor.testRunCommandNoPriority fails in branch-2. But it passed in trunk.
> The function code ContainerExecutor.getRunCommand() in trunk is different from that in branch-2.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)