You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by pa...@apache.org on 2018/06/27 18:56:21 UTC

[2/7] [lang] deletes redundant 'new' expression in constant array creation

deletes redundant 'new' expression in constant array creation


Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/96260205
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/96260205
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/96260205

Branch: refs/heads/master
Commit: 96260205dceea0e4734fa275c8f72a617bd8ebc4
Parents: e767af7
Author: Igor Curdvanovschi <in...@gmail.com>
Authored: Wed Jun 20 12:44:10 2018 +0300
Committer: Igor Curdvanovschi <in...@gmail.com>
Committed: Wed Jun 20 12:44:10 2018 +0300

----------------------------------------------------------------------
 .../org/apache/commons/lang3/CharUtils.java     |  2 +-
 .../org/apache/commons/lang3/Conversion.java    | 32 ++++++++++----------
 .../apache/commons/lang3/StringEscapeUtils.java |  6 ++--
 .../apache/commons/lang3/reflect/TypeUtils.java |  2 +-
 .../text/translate/CharSequenceTranslator.java  |  2 +-
 5 files changed, 21 insertions(+), 23 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-lang/blob/96260205/src/main/java/org/apache/commons/lang3/CharUtils.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/lang3/CharUtils.java b/src/main/java/org/apache/commons/lang3/CharUtils.java
index c228968..3c8ad3e 100644
--- a/src/main/java/org/apache/commons/lang3/CharUtils.java
+++ b/src/main/java/org/apache/commons/lang3/CharUtils.java
@@ -30,7 +30,7 @@ public class CharUtils {
 
     private static final String[] CHAR_STRING_ARRAY = new String[128];
 
-    private static final char[] HEX_DIGITS = new char[] {'0','1','2','3','4','5','6','7','8','9','a','b','c','d','e','f'};
+    private static final char[] HEX_DIGITS = {'0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'a', 'b', 'c', 'd', 'e', 'f'};
 
     /**
      * {@code \u000a} linefeed LF ('\n').

http://git-wip-us.apache.org/repos/asf/commons-lang/blob/96260205/src/main/java/org/apache/commons/lang3/Conversion.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/lang3/Conversion.java b/src/main/java/org/apache/commons/lang3/Conversion.java
index 0427dee..5577be4 100644
--- a/src/main/java/org/apache/commons/lang3/Conversion.java
+++ b/src/main/java/org/apache/commons/lang3/Conversion.java
@@ -65,22 +65,22 @@ import java.util.UUID;
 
 public class Conversion {
 
-    private static final boolean[] TTTT = new boolean[] { true, true, true, true };
-    private static final boolean[] FTTT = new boolean[] { false, true, true, true };
-    private static final boolean[] TFTT = new boolean[] { true, false, true, true };
-    private static final boolean[] FFTT = new boolean[] { false, false, true, true };
-    private static final boolean[] TTFT = new boolean[] { true, true, false, true };
-    private static final boolean[] FTFT = new boolean[] { false, true, false, true };
-    private static final boolean[] TFFT = new boolean[] { true, false, false, true };
-    private static final boolean[] FFFT = new boolean[] { false, false, false, true };
-    private static final boolean[] TTTF = new boolean[] { true, true, true, false };
-    private static final boolean[] FTTF = new boolean[] { false, true, true, false };
-    private static final boolean[] TFTF = new boolean[] { true, false, true, false };
-    private static final boolean[] FFTF = new boolean[] { false, false, true, false };
-    private static final boolean[] TTFF = new boolean[] { true, true, false, false };
-    private static final boolean[] FTFF = new boolean[] { false, true, false, false };
-    private static final boolean[] TFFF = new boolean[] { true, false, false, false };
-    private static final boolean[] FFFF = new boolean[] { false, false, false, false };
+    private static final boolean[] TTTT = {true, true, true, true};
+    private static final boolean[] FTTT = {false, true, true, true};
+    private static final boolean[] TFTT = {true, false, true, true};
+    private static final boolean[] FFTT = {false, false, true, true};
+    private static final boolean[] TTFT = {true, true, false, true};
+    private static final boolean[] FTFT = {false, true, false, true};
+    private static final boolean[] TFFT = {true, false, false, true};
+    private static final boolean[] FFFT = {false, false, false, true};
+    private static final boolean[] TTTF = {true, true, true, false};
+    private static final boolean[] FTTF = {false, true, true, false};
+    private static final boolean[] TFTF = {true, false, true, false};
+    private static final boolean[] FFTF = {false, false, true, false};
+    private static final boolean[] TTFF = {true, true, false, false};
+    private static final boolean[] FTFF = {false, true, false, false};
+    private static final boolean[] TFFF = {true, false, false, false};
+    private static final boolean[] FFFF = {false, false, false, false};
 
     /**
      * <p>

http://git-wip-us.apache.org/repos/asf/commons-lang/blob/96260205/src/main/java/org/apache/commons/lang3/StringEscapeUtils.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/lang3/StringEscapeUtils.java b/src/main/java/org/apache/commons/lang3/StringEscapeUtils.java
index 2d0a5db..ce7eec5 100644
--- a/src/main/java/org/apache/commons/lang3/StringEscapeUtils.java
+++ b/src/main/java/org/apache/commons/lang3/StringEscapeUtils.java
@@ -255,8 +255,7 @@ public class StringEscapeUtils {
         private static final char CSV_DELIMITER = ',';
         private static final char CSV_QUOTE = '"';
         private static final String CSV_QUOTE_STR = String.valueOf(CSV_QUOTE);
-        private static final char[] CSV_SEARCH_CHARS =
-            new char[] {CSV_DELIMITER, CSV_QUOTE, CharUtils.CR, CharUtils.LF};
+        private static final char[] CSV_SEARCH_CHARS = { CSV_DELIMITER, CSV_QUOTE, CharUtils.CR, CharUtils.LF };
 
         @Override
         public int translate(final CharSequence input, final int index, final Writer out) throws IOException {
@@ -389,8 +388,7 @@ public class StringEscapeUtils {
         private static final char CSV_DELIMITER = ',';
         private static final char CSV_QUOTE = '"';
         private static final String CSV_QUOTE_STR = String.valueOf(CSV_QUOTE);
-        private static final char[] CSV_SEARCH_CHARS =
-            new char[] {CSV_DELIMITER, CSV_QUOTE, CharUtils.CR, CharUtils.LF};
+        private static final char[] CSV_SEARCH_CHARS = {CSV_DELIMITER, CSV_QUOTE, CharUtils.CR, CharUtils.LF};
 
         @Override
         public int translate(final CharSequence input, final int index, final Writer out) throws IOException {

http://git-wip-us.apache.org/repos/asf/commons-lang/blob/96260205/src/main/java/org/apache/commons/lang3/reflect/TypeUtils.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/lang3/reflect/TypeUtils.java b/src/main/java/org/apache/commons/lang3/reflect/TypeUtils.java
index deacce1..a421d5c 100644
--- a/src/main/java/org/apache/commons/lang3/reflect/TypeUtils.java
+++ b/src/main/java/org/apache/commons/lang3/reflect/TypeUtils.java
@@ -1825,7 +1825,7 @@ public class TypeUtils {
 
     private static int[] findRecursiveTypes(final ParameterizedType p) {
         final Type[] filteredArgumentTypes = Arrays.copyOf(p.getActualTypeArguments(), p.getActualTypeArguments().length);
-        int[] indexesToRemove = new int[] {};
+        int[] indexesToRemove = {};
         for (int i = 0; i < filteredArgumentTypes.length; i++) {
             if (filteredArgumentTypes[i] instanceof TypeVariable<?>) {
                 if (containsVariableTypeSameParametrizedTypeBound(((TypeVariable<?>) filteredArgumentTypes[i]), p)) {

http://git-wip-us.apache.org/repos/asf/commons-lang/blob/96260205/src/main/java/org/apache/commons/lang3/text/translate/CharSequenceTranslator.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/lang3/text/translate/CharSequenceTranslator.java b/src/main/java/org/apache/commons/lang3/text/translate/CharSequenceTranslator.java
index e79ebe6..cac63bf 100644
--- a/src/main/java/org/apache/commons/lang3/text/translate/CharSequenceTranslator.java
+++ b/src/main/java/org/apache/commons/lang3/text/translate/CharSequenceTranslator.java
@@ -34,7 +34,7 @@ import java.util.Locale;
 @Deprecated
 public abstract class CharSequenceTranslator {
 
-    static final char[] HEX_DIGITS = new char[] {'0','1','2','3','4','5','6','7','8','9','A','B','C','D','E','F'};
+    static final char[] HEX_DIGITS = {'0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'A', 'B', 'C', 'D', 'E', 'F'};
 
     /**
      * Translate a set of codepoints, represented by an int index into a CharSequence,