You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@baremaps.apache.org by "bchapuis (via GitHub)" <gi...@apache.org> on 2023/08/15 21:08:40 UTC
[GitHub] [incubator-baremaps] bchapuis opened a new pull request, #747: Improve style source deserialization
bchapuis opened a new pull request, #747:
URL: https://github.com/apache/incubator-baremaps/pull/747
Fixes #746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-baremaps] sonarcloud[bot] commented on pull request #747: Improve style source deserialization
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #747:
URL: https://github.com/apache/incubator-baremaps/pull/747#issuecomment-1679645522
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_baremaps&pullRequest=747)
[](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=747&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=747&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=747&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=747&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=747&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=747&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_baremaps&pullRequest=747&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_baremaps&pullRequest=747&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_baremaps&pullRequest=747&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=747&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=747&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=747&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_baremaps&pullRequest=747) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_baremaps&pullRequest=747&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_baremaps&pullRequest=747&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-baremaps] sonarcloud[bot] commented on pull request #747: Improve style source deserialization
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #747:
URL: https://github.com/apache/incubator-baremaps/pull/747#issuecomment-1679629255
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_baremaps&pullRequest=747)
[](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=747&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=747&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=747&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=747&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=747&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=747&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_baremaps&pullRequest=747&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_baremaps&pullRequest=747&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_baremaps&pullRequest=747&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=747&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=747&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=747&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_baremaps&pullRequest=747) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_baremaps&pullRequest=747&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_baremaps&pullRequest=747&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-baremaps] sonarcloud[bot] commented on pull request #747: Improve style source deserialization
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #747:
URL: https://github.com/apache/incubator-baremaps/pull/747#issuecomment-1679623409
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_baremaps&pullRequest=747)
[](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=747&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=747&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=747&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=747&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=747&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=747&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_baremaps&pullRequest=747&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_baremaps&pullRequest=747&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_baremaps&pullRequest=747&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=747&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=747&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=747&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_baremaps&pullRequest=747) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_baremaps&pullRequest=747&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_baremaps&pullRequest=747&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-baremaps] github-code-scanning[bot] commented on a diff in pull request #747: Improve style source deserialization
Posted by "github-code-scanning[bot] (via GitHub)" <gi...@apache.org>.
github-code-scanning[bot] commented on code in PR #747:
URL: https://github.com/apache/incubator-baremaps/pull/747#discussion_r1295120832
##########
baremaps-core/src/test/java/org/apache/baremaps/config/ConfigReaderTest.java:
##########
@@ -0,0 +1,33 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
+ * in compliance with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+ * or implied. See the License for the specific language governing permissions and limitations under
+ * the License.
+ */
+
+package org.apache.baremaps.config;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import java.io.IOException;
+import org.apache.baremaps.testing.TestFiles;
+import org.apache.baremaps.vectortile.style.Style;
+import org.junit.jupiter.api.Test;
+import org.testcontainers.shaded.com.fasterxml.jackson.databind.ObjectMapper;
+
+class ConfigReaderTest {
Review Comment:
## Unused classes and interfaces
Unused class: ConfigReaderTest is not referenced within this codebase. If not used as an external API it should be removed.
[Show more details](https://github.com/apache/incubator-baremaps/security/code-scanning/784)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-baremaps] sonarcloud[bot] commented on pull request #747: Improve style source deserialization
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #747:
URL: https://github.com/apache/incubator-baremaps/pull/747#issuecomment-1679666678
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_baremaps&pullRequest=747)
[](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=747&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=747&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=747&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=747&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=747&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=747&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_baremaps&pullRequest=747&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_baremaps&pullRequest=747&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_baremaps&pullRequest=747&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=747&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=747&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=747&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_baremaps&pullRequest=747) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_baremaps&pullRequest=747&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_baremaps&pullRequest=747&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-baremaps] bchapuis merged pull request #747: Improve style source deserialization
Posted by "bchapuis (via GitHub)" <gi...@apache.org>.
bchapuis merged PR #747:
URL: https://github.com/apache/incubator-baremaps/pull/747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org