[GitHub] [incubator-iceberg] aokolnychyi opened a new pull request #226: Apply Baseline plugin to iceberg-spark

[GitBox <gi...@apache.org>]

aokolnychyi opened a new pull request #226: Apply Baseline plugin to iceberg-spark
URL: https://github.com/apache/incubator-iceberg/pull/226
 
 
   This PR applies Baseline to iceberg-spark and resolves #161. 
   
   **Open Questions**
   - I’ve added `org.apache.spark.sql.functions.*` to the whitelist of static imports.
   - Not sure about the best style in `SparkOrcReader`.
   - I’ve changed `UTF8` to `Utf8` because Baseline required this.
   - I’ve kept separate code blocks in `TestFilteredScan` as it gives better readability.
   - I’ve replaced Hortonworks copyright in `SimpleRecord`.
   - I’ve picked the default Scala formatting from Baseline.
       - It is impossible to change the location of `scalastyle.xml` in Baseline.
       - License is checked in the same way as in Java (not full, just start). Shall we check the complete license?
       - I’ve removed `ImportGroupingChecker` to support `import spark.implicits._`
       - Baseline doesn’t include `ImportOrderChecker` by default. Shall we add it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org