You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/01/25 06:29:49 UTC

[GitHub] [incubator-yunikorn-site] yangwwei opened a new pull request #111: [YUNIKORN-1021] Add committer/PPMC user list on the website.

yangwwei opened a new pull request #111:
URL: https://github.com/apache/incubator-yunikorn-site/pull/111


   This adds a page at community/people, and a list of PPMC/committer names.
   And move "become a committer/PPMC" to this page because it is more relevant.
   Sorry forgot to take a screenshot, but I've tested this locally, it works fine. Please help to review the content. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-yunikorn-site] yangwwei merged pull request #111: [YUNIKORN-1021] Add committer/PPMC user list on the website.

Posted by GitBox <gi...@apache.org>.
yangwwei merged pull request #111:
URL: https://github.com/apache/incubator-yunikorn-site/pull/111


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-yunikorn-site] yuchaoran2011 commented on a change in pull request #111: [YUNIKORN-1021] Add committer/PPMC user list on the website.

Posted by GitBox <gi...@apache.org>.
yuchaoran2011 commented on a change in pull request #111:
URL: https://github.com/apache/incubator-yunikorn-site/pull/111#discussion_r791411751



##########
File path: src/pages/community/people.md
##########
@@ -0,0 +1,104 @@
+---
+id: people
+title: Who We Are
+---
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+## Project Members
+
+YuniKorn community is open, diverse, and collaborative. It is not owned
+by any entity. Project members share the responsibility to manage, and maintain the project.
+People in the community includes PPMC ([Podling Project Management Committee](https://incubator.apache.org/guides/ppmc.html))

Review comment:
       It's a convention to put the acronyms in parentheses after the full expanded name

##########
File path: src/pages/community/people.md
##########
@@ -0,0 +1,104 @@
+---
+id: people
+title: Who We Are
+---
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+## Project Members
+
+YuniKorn community is open, diverse, and collaborative. It is not owned
+by any entity. Project members share the responsibility to manage, and maintain the project.
+People in the community includes PPMC ([Podling Project Management Committee](https://incubator.apache.org/guides/ppmc.html))

Review comment:
       ```suggestion
   People in the community include Podling Project Management Committee ([PPMC](https://incubator.apache.org/guides/ppmc.html))
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-yunikorn-site] yuchaoran2011 commented on a change in pull request #111: [YUNIKORN-1021] Add committer/PPMC user list on the website.

Posted by GitBox <gi...@apache.org>.
yuchaoran2011 commented on a change in pull request #111:
URL: https://github.com/apache/incubator-yunikorn-site/pull/111#discussion_r791411751



##########
File path: src/pages/community/people.md
##########
@@ -0,0 +1,104 @@
+---
+id: people
+title: Who We Are
+---
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+## Project Members
+
+YuniKorn community is open, diverse, and collaborative. It is not owned
+by any entity. Project members share the responsibility to manage, and maintain the project.
+People in the community includes PPMC ([Podling Project Management Committee](https://incubator.apache.org/guides/ppmc.html))

Review comment:
       It's a convention to put the acronyms in parentheses after the full expanded name

##########
File path: src/pages/community/people.md
##########
@@ -0,0 +1,104 @@
+---
+id: people
+title: Who We Are
+---
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+## Project Members
+
+YuniKorn community is open, diverse, and collaborative. It is not owned
+by any entity. Project members share the responsibility to manage, and maintain the project.
+People in the community includes PPMC ([Podling Project Management Committee](https://incubator.apache.org/guides/ppmc.html))

Review comment:
       ```suggestion
   People in the community include Podling Project Management Committee ([PPMC](https://incubator.apache.org/guides/ppmc.html))
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-yunikorn-site] yangwwei commented on a change in pull request #111: [YUNIKORN-1021] Add committer/PPMC user list on the website.

Posted by GitBox <gi...@apache.org>.
yangwwei commented on a change in pull request #111:
URL: https://github.com/apache/incubator-yunikorn-site/pull/111#discussion_r791977611



##########
File path: src/pages/community/people.md
##########
@@ -0,0 +1,104 @@
+---
+id: people
+title: Who We Are
+---
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+## Project Members
+
+YuniKorn community is open, diverse, and collaborative. It is not owned
+by any entity. Project members share the responsibility to manage, and maintain the project.
+People in the community includes PPMC ([Podling Project Management Committee](https://incubator.apache.org/guides/ppmc.html))

Review comment:
       Fixed, thanks




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org