You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2023/12/17 21:26:01 UTC
[PR] WIP: Upgrade to DataFusion 34 [arrow-datafusion-python]
andygrove opened a new pull request, #550:
URL: https://github.com/apache/arrow-datafusion-python/pull/550
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
N/A
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prepare 34.0.0 Release [arrow-datafusion-python]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #550:
URL: https://github.com/apache/arrow-datafusion-python/pull/550#discussion_r1437877813
##########
src/dataframe.rs:
##########
@@ -36,7 +36,7 @@ use std::sync::Arc;
/// The actual execution of a plan runs natively on Rust and Arrow on a multi-threaded environment.
#[pyclass(name = "DataFrame", module = "datafusion", subclass)]
#[derive(Clone)]
-pub(crate) struct PyDataFrame {
+pub struct PyDataFrame {
Review Comment:
I see. Thanks for the reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prepare 34.0.0 Release [arrow-datafusion-python]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #550:
URL: https://github.com/apache/arrow-datafusion-python/pull/550#discussion_r1437831099
##########
src/dataframe.rs:
##########
@@ -36,7 +36,7 @@ use std::sync::Arc;
/// The actual execution of a plan runs natively on Rust and Arrow on a multi-threaded environment.
#[pyclass(name = "DataFrame", module = "datafusion", subclass)]
#[derive(Clone)]
-pub(crate) struct PyDataFrame {
+pub struct PyDataFrame {
Review Comment:
This is also due to 34.0.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade to DataFusion 34 [arrow-datafusion-python]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #550:
URL: https://github.com/apache/arrow-datafusion-python/pull/550#issuecomment-1870596586
@jdye64 fyi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prepare 34.0.0 Release [arrow-datafusion-python]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #550:
URL: https://github.com/apache/arrow-datafusion-python/pull/550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prepare 34.0.0 Release [arrow-datafusion-python]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #550:
URL: https://github.com/apache/arrow-datafusion-python/pull/550#discussion_r1437856266
##########
src/dataframe.rs:
##########
@@ -36,7 +36,7 @@ use std::sync::Arc;
/// The actual execution of a plan runs natively on Rust and Arrow on a multi-threaded environment.
#[pyclass(name = "DataFrame", module = "datafusion", subclass)]
#[derive(Clone)]
-pub(crate) struct PyDataFrame {
+pub struct PyDataFrame {
Review Comment:
I removed the `(crate)` restriction to work around many warnings like the following. I wonder if this was caused by a recent Rust version upgrade rather than anything related to 34.0.0.
```
warning: type `PyDataFrame` is more private than the item `PySessionContext::sql`
--> src/context.rs:282:5
|
282 | pub fn sql(&mut self, query: &str, py: Python) -> PyResult<PyDataFrame> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ method `PySessionContext::sql` is reachable at visibility `pub`
|
note: but type `PyDataFrame` is only usable at visibility `pub(crate)`
--> src/dataframe.rs:39:1
|
39 | pub(crate) struct PyDataFrame {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: `#[warn(private_interfaces)]` on by default
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prepare 34.0.0 Release [arrow-datafusion-python]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #550:
URL: https://github.com/apache/arrow-datafusion-python/pull/550#discussion_r1437862116
##########
src/dataframe.rs:
##########
@@ -36,7 +36,7 @@ use std::sync::Arc;
/// The actual execution of a plan runs natively on Rust and Arrow on a multi-threaded environment.
#[pyclass(name = "DataFrame", module = "datafusion", subclass)]
#[derive(Clone)]
-pub(crate) struct PyDataFrame {
+pub struct PyDataFrame {
Review Comment:
There is a reference to `private_interfaces` in the [release notes](https://releases.rs/docs/1.74.0/) for Rust 1.74.0, which was released last month.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prepare 34.0.0 Release [arrow-datafusion-python]
Posted by "jdye64 (via GitHub)" <gi...@apache.org>.
jdye64 commented on code in PR #550:
URL: https://github.com/apache/arrow-datafusion-python/pull/550#discussion_r1437834313
##########
src/dataframe.rs:
##########
@@ -36,7 +36,7 @@ use std::sync::Arc;
/// The actual execution of a plan runs natively on Rust and Arrow on a multi-threaded environment.
#[pyclass(name = "DataFrame", module = "datafusion", subclass)]
#[derive(Clone)]
-pub(crate) struct PyDataFrame {
+pub struct PyDataFrame {
Review Comment:
I don't think directly. I will say having lots of these "(crate)" level visibility of structs makes using ADP as a library difficult since they are not visible outside the crate. I had started removing them awhile back and think Andy was just removing another one of them. I should probably just make a PR to remove them all, where it makes sense of course
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org