You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/17 14:28:39 UTC
[GitHub] [airflow] ashb opened a new pull request, #25767: Fix outlet datasets not being detected on Mapped operators
ashb opened a new pull request, #25767:
URL: https://github.com/apache/airflow/pull/25767
The "driving" factor of this was confusion/inconsistency over where
outlets are stored. For BaseOperator it was stored on `self._outlets`, (but
at execution time the `@prepare_lineage` decorator would munge it and
move things in to `self.outlets`.
But for MappedOperators a) this munging never took place, and b) it
stored it on `self.outlets`.
This PR removes the ambiguity and always stores inlets/outlets in the
"public" attribute.
As a "bonus" change, this doesn't store empty lists in the serialized
DAG for these two attributes
(There's still some other problem going on with datasets + mapped tasks when it comes to actually running the tasks though)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #25767: Fix outlet datasets not being detected on Mapped operators
Posted by GitBox <gi...@apache.org>.
ashb merged PR #25767:
URL: https://github.com/apache/airflow/pull/25767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #25767: Fix outlet datasets not being detected on Mapped operators
Posted by GitBox <gi...@apache.org>.
ashb commented on PR #25767:
URL: https://github.com/apache/airflow/pull/25767#issuecomment-1218176665
Ah, the issue with it not "working" is already reported by Matt https://github.com/apache/airflow/issues/25210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org