You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/08/02 19:08:01 UTC

[GitHub] [netbeans] matthiasblaesing opened a new pull request #3085: [Netbeans-5734] Quick fix to make NB 12.4+ run Glassfish 6.1 on JDK 11+

matthiasblaesing opened a new pull request #3085:
URL: https://github.com/apache/netbeans/pull/3085


   This PR is a cleaned up and enhanced version of #3056. It was also rebased onto the release125 branch.
   
   This is primary a bug fix, so should be considered for 12.5.
   
   Closes: #3056 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] matthiasblaesing commented on pull request #3085: [Netbeans-5734] Quick fix to make NB 12.4+ run Glassfish 6.1 on JDK 11+

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #3085:
URL: https://github.com/apache/netbeans/pull/3085#issuecomment-891266135


   @juneau001 
   
   For a discussion please see the referenced original PR. This is the consolidated version, I'd appreciate opinions as I currently don't use glassfish myself and so working from past experiences.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] ebarboni merged pull request #3085: [Netbeans-5734] Quick fix to make NB 12.4+ run Glassfish 6.1 on JDK 11+

Posted by GitBox <gi...@apache.org>.
ebarboni merged pull request #3085:
URL: https://github.com/apache/netbeans/pull/3085


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] neilcsmith-net commented on pull request #3085: [Netbeans-5734] Quick fix to make NB 12.4+ run Glassfish 6.1 on JDK 11+

Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #3085:
URL: https://github.com/apache/netbeans/pull/3085#issuecomment-891279998


   👍 Should be based on delivery branch though (which I guess won't make a difference yet).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] matthiasblaesing commented on pull request #3085: [Netbeans-5734] Quick fix to make NB 12.4+ run Glassfish 6.1 on JDK 11+

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #3085:
URL: https://github.com/apache/netbeans/pull/3085#issuecomment-891287902


   @neilcsmith-net thanks for the check - something felt wrong, but I could not pin-point it. At this point it is indeed uncritical as the base commit is the same for all candidates, so I switched target branch in the PR settings.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] ebarboni commented on pull request #3085: [Netbeans-5734] Quick fix to make NB 12.4+ run Glassfish 6.1 on JDK 11+

Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #3085:
URL: https://github.com/apache/netbeans/pull/3085#issuecomment-891797914


   green light I will merge, and resync (I hope to success in this step) to make a "beta" with all 12.5 intended content :D


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists