You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by kavinkumarks <gi...@git.apache.org> on 2016/09/01 12:30:00 UTC
[GitHub] zeppelin pull request #1393: [ZEPPELIN-1142] Zeppelin allows two users to si...
GitHub user kavinkumarks opened a pull request:
https://github.com/apache/zeppelin/pull/1393
[ZEPPELIN-1142] Zeppelin allows two users to simultaneously edit the notebook permissions
### What is this PR for?
This is about storing the owner information on creating a note so when the same user tries to edit the permissions of the note he could do it successfully.
### What type of PR is it?
Improvement
### Todos
NA
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1142
### How should this be tested?
Check the below cases via the web application or REST API calls and the owner information should be persisted properly.
* Create note
* Clone note
* Import note
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kavinkumarks/zeppelin zeppelin-1142-simultaneous-note-permission-error
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1393.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1393
----
commit d794a2ab8549a04c173a03fcb597c4db3909fd97
Author: Kavin <ka...@imaginea.com>
Date: 2016-09-01T11:19:41Z
Store owner information on creating a note and added integration test
cases for the relevant scenarios.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1393: [ZEPPELIN-1142] Zeppelin allows two users to simultane...
Posted by kavinkumarks <gi...@git.apache.org>.
Github user kavinkumarks commented on the issue:
https://github.com/apache/zeppelin/pull/1393
Reopening to trigger the CI build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1393: [ZEPPELIN-1142] Zeppelin allows two users to simultane...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1393
@kavinkumarks thanks for improvement and it makes sense indeed to assign owner when creating note. just need to address above minor comments as well as restart CI, some profiles are failing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1393: [ZEPPELIN-1142] Zeppelin allows two users to simultane...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1393
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1393: [ZEPPELIN-1142] Zeppelin allows two users to si...
Posted by kavinkumarks <gi...@git.apache.org>.
Github user kavinkumarks closed the pull request at:
https://github.com/apache/zeppelin/pull/1393
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1393: [ZEPPELIN-1142] Zeppelin allows two users to simultane...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1393
Thanks @kavinkumarks for the contribution.
This changes not only resolving race condition described in ZEPPELIN-1142 but also changes user experience. i.e.
Before, owner is not defined when creating note.
After, owner is set to current user when creating note. (when authentication is enabled)
Especially with code changes such as https://github.com/apache/zeppelin/pull/1330, user will experience bigger behavior changes.
But i think having current user as a owner when creating note is natural behavior that most people can think, even though it brings some UX changes.
LGTM and merge if there're no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1393: [ZEPPELIN-1142] Zeppelin allows two users to simultane...
Posted by kavinkumarks <gi...@git.apache.org>.
Github user kavinkumarks commented on the issue:
https://github.com/apache/zeppelin/pull/1393
Fixed the build test failure and the CI build is in progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1393: [ZEPPELIN-1142] Zeppelin allows two users to si...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1393
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1393: [ZEPPELIN-1142] Zeppelin allows two users to simultane...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1393
@kavinkumarks i believe some of the committers or pmcs will take a look into this pr before merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1393: [ZEPPELIN-1142] Zeppelin allows two users to si...
Posted by kavinkumarks <gi...@git.apache.org>.
GitHub user kavinkumarks reopened a pull request:
https://github.com/apache/zeppelin/pull/1393
[ZEPPELIN-1142] Zeppelin allows two users to simultaneously edit the notebook permissions
### What is this PR for?
This is about storing the owner information on creating a note so when the same user tries to edit the permissions of the note he could do it successfully.
### What type of PR is it?
Improvement
### Todos
NA
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1142
### How should this be tested?
Check the below cases via the web application or REST API calls and the owner information should be persisted properly.
* Create note
* Clone note
* Import note
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kavinkumarks/zeppelin zeppelin-1142-simultaneous-note-permission-error
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1393.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1393
----
commit 4412692cdd48a23ccf9578ddbcfe0205784ac92d
Author: Kavin <ka...@imaginea.com>
Date: 2016-09-01T11:19:41Z
Store owner information on creating a note and added integration test
cases for the relevant scenarios.
commit 85af4e6178c82414526386ac3d72239a279789b4
Author: Kavin <ka...@imaginea.com>
Date: 2016-09-06T09:20:14Z
Removed the duplicate instance of notebook variable and reused the
existing one.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1393: [ZEPPELIN-1142] Zeppelin allows two users to simultane...
Posted by kavinkumarks <gi...@git.apache.org>.
Github user kavinkumarks commented on the issue:
https://github.com/apache/zeppelin/pull/1393
Thanks @khalidhuseynov ! Can we get this merged?
-Kavin
MailTo: kavin.kumar@imaginea.com
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1393: [ZEPPELIN-1142] Zeppelin allows two users to simultane...
Posted by kavinkumarks <gi...@git.apache.org>.
Github user kavinkumarks commented on the issue:
https://github.com/apache/zeppelin/pull/1393
@khalidhuseynov thanks for the review! I have replied to the comments and the CI build is in progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1393: [ZEPPELIN-1142] Zeppelin allows two users to simultane...
Posted by kavinkumarks <gi...@git.apache.org>.
Github user kavinkumarks commented on the issue:
https://github.com/apache/zeppelin/pull/1393
Could someone else have a look at this and merge if everything is okay?
Thanks,
Kavin
MailTo: kavin.kumar@imaginea.com
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1393: [ZEPPELIN-1142] Zeppelin allows two users to simultane...
Posted by kavinkumarks <gi...@git.apache.org>.
Github user kavinkumarks commented on the issue:
https://github.com/apache/zeppelin/pull/1393
Found an build test failure, working on it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1393: [ZEPPELIN-1142] Zeppelin allows two users to simultane...
Posted by kavinkumarks <gi...@git.apache.org>.
Github user kavinkumarks commented on the issue:
https://github.com/apache/zeppelin/pull/1393
The CI build is green.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1393: [ZEPPELIN-1142] Zeppelin allows two users to simultane...
Posted by kavinkumarks <gi...@git.apache.org>.
Github user kavinkumarks commented on the issue:
https://github.com/apache/zeppelin/pull/1393
Thanks @Leemoonsoo for reviewing this! Could you please merge this?
- Kavin
MailTo: kavin.kumar@imaginea.com
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---