[jira] [Commented] (FLINK-8631) Add support for generic response types to RestClient

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359669#comment-16359669 ] 

ASF GitHub Bot commented on FLINK-8631:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/5450

    [FLINK-8631] [rest] Add support for generic types to the RestClient

    ## What is the purpose of the change
    
    This commit allows the Restclient to receive generic response types. In order
    to do this, the MessageHeaders contain now information about the generic
    type parameters of the response type.
    
    ## Brief change log
    
    - Extend `MessageHeaders` to have `getResponseTypeParameters` method
    - Adapt `RestClient` to take type parameters into consideration when receiving a response
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink generifyRestClient

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5450.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5450
    
----
commit b0efaa09c3b39e31ba130c668abe39af40473fb4
Author: Till Rohrmann <tr...@...>
Date:   2018-02-03T16:41:51Z

    [FLINK-8631] [rest] Add support for generic types to the RestClient
    
    This commit allows the Restclient to receive generic response types. In order
    to do this, the MessageHeaders contain now information about the generic
    type parameters of the response type.

----


> Add support for generic response types to RestClient
> ----------------------------------------------------
>
>                 Key: FLINK-8631
>                 URL: https://issues.apache.org/jira/browse/FLINK-8631
>             Project: Flink
>          Issue Type: New Feature
>          Components: REST
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Major
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> In order to send generic response types to the {{RestClient}} we have to enhance the {{MessageHeaders}} to also contain a collection of type parameters.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)