[GitHub] [incubator-mxnet] PawelGlomski-Intel commented on a change in pull request #20606: [submodule] Remove soon to be obsolete dnnl nomenclature from mxnet

[GitBox <gi...@apache.org>]

PawelGlomski-Intel commented on a change in pull request #20606:
URL: https://github.com/apache/incubator-mxnet/pull/20606#discussion_r721221157



##########
File path: src/operator/subgraph/dnnl/dnnl_transformer.cc
##########
@@ -23,25 +23,24 @@
 #include <utility>
 #include <vector>
 
-#include "./mkldnn_transformer-inl.h"
-
 #include "../../contrib/transformer-inl.h"
 #include "../../quantization/quantization_utils.h"
 #include "../../tensor/elemwise_unary_op.h"
 #include "../common.h"
+#include "./dnnl_transformer-inl.h"

Review comment:
       Other than that, LGTM

##########
File path: src/operator/subgraph/dnnl/dnnl_transformer.cc
##########
@@ -23,25 +23,24 @@
 #include <utility>
 #include <vector>
 
-#include "./mkldnn_transformer-inl.h"
-
 #include "../../contrib/transformer-inl.h"
 #include "../../quantization/quantization_utils.h"
 #include "../../tensor/elemwise_unary_op.h"
 #include "../common.h"
+#include "./dnnl_transformer-inl.h"

Review comment:
       Changed order of includes?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org