[jira] [Commented] (LUCENE-4057) Add Codec.merge()

["Michael McCandless (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-4057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274695#comment-13274695 ] 

Michael McCandless commented on LUCENE-4057:
--------------------------------------------

+1
                
> Add Codec.merge()
> -----------------
>
>                 Key: LUCENE-4057
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4057
>             Project: Lucene - Java
>          Issue Type: Improvement
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>             Fix For: 4.1
>
>
> Currently individual codec components can override/optimize merging, e.g. the stored fields impl
> uses bulk copying when possible, and so on.
> SegmentMerger contains the logic for merging the different codec components, for example it does
> mergeFieldInfos(), then mergeFields(), mergeTerms(), and so on. Each of these methods interacts
> with the codec apis to finish the merge.
> I think it would be cleaner if SegmentMerger called a new method, Codec.merge(), which contained
> this logic instead. This way someone could customize this process. I think we could probably even 
> push some of the impl-dependent stuff (like matchingSegmentReaders) into the impl and out of SegmentMerger.
> Setting this for 4.1, I think it would be a nice cleanup but I don't plan on working on this immediately, 
> and I think we can do this in a backwards compatible way in a minor release.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org