You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ms...@apache.org on 2015/05/20 12:57:13 UTC
svn commit: r1680519 - in
/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf:
FDFAnnotationLine.java FDFAnnotationPolygon.java FDFAnnotationPolyline.java
FDFAnnotationTextMarkup.java
Author: msahyoun
Date: Wed May 20 10:57:12 2015
New Revision: 1680519
URL: http://svn.apache.org/r1680519
Log:
PDFBOX-2758: fix isEmpty() check for strings
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationLine.java
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationPolygon.java
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationPolyline.java
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationTextMarkup.java
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationLine.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationLine.java?rev=1680519&r1=1680518&r2=1680519&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationLine.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationLine.java Wed May 20 10:57:12 2015
@@ -71,12 +71,12 @@ public class FDFAnnotationLine extends F
annot.setName(COSName.SUBTYPE, SUBTYPE);
String startCoords = element.getAttribute("start");
- if (startCoords == null || !startCoords.isEmpty())
+ if (startCoords == null || startCoords.isEmpty())
{
throw new IOException("Error: missing attribute 'start'");
}
String endCoords = element.getAttribute("end");
- if (endCoords == null || !endCoords.isEmpty())
+ if (endCoords == null || endCoords.isEmpty())
{
throw new IOException("Error: missing attribute 'end'");
}
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationPolygon.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationPolygon.java?rev=1680519&r1=1680518&r2=1680519&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationPolygon.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationPolygon.java Wed May 20 10:57:12 2015
@@ -79,7 +79,7 @@ public class FDFAnnotationPolygon extend
try
{
String vertices = xpath.evaluate("vertices", element);
- if (vertices == null || !vertices.isEmpty())
+ if (vertices == null || vertices.isEmpty())
{
throw new IOException("Error: missing element 'vertices'");
}
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationPolyline.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationPolyline.java?rev=1680519&r1=1680518&r2=1680519&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationPolyline.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationPolyline.java Wed May 20 10:57:12 2015
@@ -80,7 +80,7 @@ public class FDFAnnotationPolyline exten
try
{
String vertices = xpath.evaluate("vertices[1]", element);
- if (vertices == null || !vertices.isEmpty())
+ if (vertices == null || vertices.isEmpty())
{
throw new IOException("Error: missing element 'vertices'");
}
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationTextMarkup.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationTextMarkup.java?rev=1680519&r1=1680518&r2=1680519&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationTextMarkup.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationTextMarkup.java Wed May 20 10:57:12 2015
@@ -60,7 +60,7 @@ public abstract class FDFAnnotationTextM
super(element);
String coords = element.getAttribute("coords");
- if (coords == null || !coords.isEmpty())
+ if (coords == null || coords.isEmpty())
{
throw new IOException("Error: missing attribute 'coords'");
}