You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by "Luis Fernando Planella Gonzalez (JIRA)" <ji...@apache.org> on 2009/11/16 14:17:39 UTC
[jira] Updated: (OPENEJB-1027) Add the application name to the data
sources matching heuristics
[ https://issues.apache.org/jira/browse/OPENEJB-1027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Luis Fernando Planella Gonzalez updated OPENEJB-1027:
-----------------------------------------------------
Attachment: AutoConfig.java
AutoConfigPersistenceUnitsTest.java
dataSourceFromWebAppContext.patch
Attached is a patch to be applied on the project root, and modified both AutoConfig and AutoConfigPersistenceUnitsTest. Both of these classes are also attached for anyone wishing to quickly see those modified classes.
What was changed:
* The AutoConfig now uses, when neither jta-data-source nor non-jta-data-source were provided in the persistence.xml, the root application context name of the first available WebModules (if any).
* The AutoConfigPersistenceUnitsTest adds 3 test cases which will cover that functionality: An application with a given web module, having:
- A matching data source with JtaManaged = true.
- A matching data source with JtaManaged = false.
- A matching data source without specifying the JtaManaged property.
> Add the application name to the data sources matching heuristics
> ----------------------------------------------------------------
>
> Key: OPENEJB-1027
> URL: https://issues.apache.org/jira/browse/OPENEJB-1027
> Project: OpenEJB
> Issue Type: Improvement
> Affects Versions: 3.1
> Environment: Linux, amd64, java 6u13
> Reporter: Luis Fernando Planella Gonzalez
> Attachments: AutoConfig.java, AutoConfigPersistenceUnitsTest.java, dataSourceFromWebAppContext.patch
>
>
> When the data source is not specified in the persistence.xml file, there is an heuristic to resolve it.
> The application name (i.e. ear) should be used in this match, as a fallback, when the current algorithm can't find the data source.
> As suggested by David Blevins at http://mail-archives.apache.org/mod_mbox/openejb-users/200905.mbox/%3CBCA79B46-275F-41D4-898E-35D26973E766@visi.com%3E , the algorithm should be:
> 1. the name set in <jta-data-source> or <non-jta-data-source>
> 2. the name of the persistence-unit
> 3. the name of the module name (i.e. war, ejb-jar, etc.)
> 4. the name of the app name (i.e. ear)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.