You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/07/06 21:41:57 UTC
[Impala-ASF-CR] IMPALA-5030: [DOCS] Document nvl2() function
John Russell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7365
Change subject: IMPALA-5030: [DOCS] Document nvl2() function
......................................................................
IMPALA-5030: [DOCS] Document nvl2() function
Change-Id: I8497e69d0f6db3c5e17b04e49a875c3efb43fab0
---
M docs/shared/impala_common.xml
M docs/topics/impala_conditional_functions.xml
M docs/topics/impala_string_functions.xml
3 files changed, 57 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/7365/1
--
To view, visit http://gerrit.cloudera.org:8080/7365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8497e69d0f6db3c5e17b04e49a875c3efb43fab0
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] IMPALA-5030: [DOCS] Document nvl2() function
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5030: [DOCS] Document nvl2() function
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7365/1/docs/topics/impala_conditional_functions.xml
File docs/topics/impala_conditional_functions.xml:
PS1, Line 467: if(x is not null
Hmm this is a bit unfortunate but I think just a consequence of how it was implemented.
--
To view, visit http://gerrit.cloudera.org:8080/7365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8497e69d0f6db3c5e17b04e49a875c3efb43fab0
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5030: [DOCS] Document nvl2() function
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5030: [DOCS] Document nvl2() function
......................................................................
IMPALA-5030: [DOCS] Document nvl2() function
Change-Id: I8497e69d0f6db3c5e17b04e49a875c3efb43fab0
Reviewed-on: http://gerrit.cloudera.org:8080/7365
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/shared/impala_common.xml
M docs/topics/impala_conditional_functions.xml
M docs/topics/impala_string_functions.xml
3 files changed, 57 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Tim Armstrong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/7365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8497e69d0f6db3c5e17b04e49a875c3efb43fab0
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
[Impala-ASF-CR] IMPALA-5030: [DOCS] Document nvl2() function
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5030: [DOCS] Document nvl2() function
......................................................................
Patch Set 1:
Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/135/
--
To view, visit http://gerrit.cloudera.org:8080/7365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8497e69d0f6db3c5e17b04e49a875c3efb43fab0
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5030: [DOCS] Document nvl2() function
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-5030: [DOCS] Document nvl2() function
......................................................................
Patch Set 1:
I noticed that I hadn't set up the infrastructure yet to have 'added in release such-and-such' markers for new 2.9 functions. So I added that marker for both nvl2() and replace().
--
To view, visit http://gerrit.cloudera.org:8080/7365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8497e69d0f6db3c5e17b04e49a875c3efb43fab0
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5030: [DOCS] Document nvl2() function
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5030: [DOCS] Document nvl2() function
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8497e69d0f6db3c5e17b04e49a875c3efb43fab0
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-HasComments: No