You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Philippe Merle (JIRA)" <ji...@apache.org> on 2009/08/11 19:32:15 UTC
[jira] Created: (CXF-2389) patches for the client part of the jaxrs
frontend
patches for the client part of the jaxrs frontend
-------------------------------------------------
Key: CXF-2389
URL: https://issues.apache.org/jira/browse/CXF-2389
Project: CXF
Issue Type: Bug
Components: REST
Affects Versions: 2.2.3
Reporter: Philippe Merle
Priority: Trivial
Fix For: 2.2.3
Attachments: ClientProxyImpl.diff, ClientProxyImpl.java
Hi,
I am integrating the Apache CXF 2.2.3 jaxrs frontend into the FraSCAti platform (an SCA implementation).
During this work, I found some issues in the ClientProxyImpl class. See the attached patched ClientProxyImpl class and a diff file.
The patch in method setRequestHeaders() around line 255 is for the case a method is annotated with @Produces. I think that produce types if defined must be put in request headers else text/plain or application/xml must be put.
I am not sure but perhaps the loop in line 268 must be moved outside the if statement.
The patch in method handleForm() at line 354 deals with the case where the type of parameters is not String, e.g. an Integer, a Char, etc.
The last patch in method doChainedInvocation() at line 398 calls the handleForm() method when required.
I hope these patches are adequate and could be integrated into a future release of Apache CXF.
Best regards and A+
Philippe Merle
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CXF-2389) patches for the client part of the jaxrs
frontend
Posted by "Philippe Merle (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philippe Merle updated CXF-2389:
--------------------------------
Attachment: ClientProxyImpl.diff
ClientProxyImpl.java
> patches for the client part of the jaxrs frontend
> -------------------------------------------------
>
> Key: CXF-2389
> URL: https://issues.apache.org/jira/browse/CXF-2389
> Project: CXF
> Issue Type: Bug
> Components: REST
> Affects Versions: 2.2.3
> Reporter: Philippe Merle
> Priority: Trivial
> Fix For: 2.2.3
>
> Attachments: ClientProxyImpl.diff, ClientProxyImpl.java
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Hi,
> I am integrating the Apache CXF 2.2.3 jaxrs frontend into the FraSCAti platform (an SCA implementation).
> During this work, I found some issues in the ClientProxyImpl class. See the attached patched ClientProxyImpl class and a diff file.
> The patch in method setRequestHeaders() around line 255 is for the case a method is annotated with @Produces. I think that produce types if defined must be put in request headers else text/plain or application/xml must be put.
> I am not sure but perhaps the loop in line 268 must be moved outside the if statement.
> The patch in method handleForm() at line 354 deals with the case where the type of parameters is not String, e.g. an Integer, a Char, etc.
> The last patch in method doChainedInvocation() at line 398 calls the handleForm() method when required.
> I hope these patches are adequate and could be integrated into a future release of Apache CXF.
> Best regards and A+
> Philippe Merle
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CXF-2389) patches for the client part of the
jaxrs frontend
Posted by "Sergey Beryozkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sergey Beryozkin resolved CXF-2389.
-----------------------------------
Resolution: Fixed
Fix Version/s: 2.3
Hi Philippe
Thanks for your patch, it's been applied, I added a couple of tests as well.
I haven't applied your first update as is but instead fixed a typo in the existing code (getConsumeTypes was checked by mistake), due to the fact that oper.getProducesTypes() always returns non-empty list, with */* if no annotations have been applied.
I also refactored the code slightly to make it clearer why accept headers were set inside an if loop
The last update seemed equivalent to what was there (in doChainedInvocations()) but I thought your code was cleaner so I applied it too.
thanks, Sergey
> patches for the client part of the jaxrs frontend
> -------------------------------------------------
>
> Key: CXF-2389
> URL: https://issues.apache.org/jira/browse/CXF-2389
> Project: CXF
> Issue Type: Bug
> Components: REST
> Affects Versions: 2.2.3
> Reporter: Philippe Merle
> Priority: Trivial
> Fix For: 2.3, 2.2.3
>
> Attachments: ClientProxyImpl.diff, ClientProxyImpl.java
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Hi,
> I am integrating the Apache CXF 2.2.3 jaxrs frontend into the FraSCAti platform (an SCA implementation).
> During this work, I found some issues in the ClientProxyImpl class. See the attached patched ClientProxyImpl class and a diff file.
> The patch in method setRequestHeaders() around line 255 is for the case a method is annotated with @Produces. I think that produce types if defined must be put in request headers else text/plain or application/xml must be put.
> I am not sure but perhaps the loop in line 268 must be moved outside the if statement.
> The patch in method handleForm() at line 354 deals with the case where the type of parameters is not String, e.g. an Integer, a Char, etc.
> The last patch in method doChainedInvocation() at line 398 calls the handleForm() method when required.
> I hope these patches are adequate and could be integrated into a future release of Apache CXF.
> Best regards and A+
> Philippe Merle
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.