You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/04/14 06:28:36 UTC
[GitHub] [incubator-nuttx] Barry-Xu-2018 commented on a change in pull request #3542: Support different hardware version of Wi-Fi add-on board (iS110B)
Barry-Xu-2018 commented on a change in pull request #3542:
URL: https://github.com/apache/incubator-nuttx/pull/3542#discussion_r612969997
##########
File path: boards/arm/cxd56xx/common/src/cxd56_gs2200m.c
##########
@@ -47,6 +47,20 @@
#define SPI_TX_MAXSIZE (CONFIG_CXD56_DMAC_SPI5_TX_MAXSIZE)
#define SPI_RX_MAXSIZE (CONFIG_CXD56_DMAC_SPI5_RX_MAXSIZE)
+#if defined(CONFIG_WIFI_BOARD_IS110B_HARDWARE_VERSION_10B)
+/* v1.0b */
+#define GS2200M_GPIO_37 (PIN_UART2_CTS)
+#define GS2200M_EXT_RTC_RESET_IN (PIN_EMMC_DATA3)
+#elif defined(CONFIG_WIFI_BOARD_IS110B_HARDWARE_VERSION_10C)
+/* v1.0c */
+#define GS2200M_GPIO_37 (PIN_EMMC_DATA2)
+#define GS2200M_EXT_RTC_RESET_IN (PIN_EMMC_DATA3)
+#else
Review comment:
> (nitpick) is this actually possible to happen? how about using `elif` statement explicitly check the configuration?
`else` means default setting. In Kconfig, I configure v1.0A as default haredware version. So I not check CONFIG_WIFI_BOARD_IS110B_HARDWARE_VERSION_10A in `else` codes.
##########
File path: boards/arm/cxd56xx/common/src/cxd56_gs2200m.c
##########
@@ -47,6 +47,20 @@
#define SPI_TX_MAXSIZE (CONFIG_CXD56_DMAC_SPI5_TX_MAXSIZE)
#define SPI_RX_MAXSIZE (CONFIG_CXD56_DMAC_SPI5_RX_MAXSIZE)
+#if defined(CONFIG_WIFI_BOARD_IS110B_HARDWARE_VERSION_10B)
+/* v1.0b */
+#define GS2200M_GPIO_37 (PIN_UART2_CTS)
+#define GS2200M_EXT_RTC_RESET_IN (PIN_EMMC_DATA3)
+#elif defined(CONFIG_WIFI_BOARD_IS110B_HARDWARE_VERSION_10C)
+/* v1.0c */
+#define GS2200M_GPIO_37 (PIN_EMMC_DATA2)
+#define GS2200M_EXT_RTC_RESET_IN (PIN_EMMC_DATA3)
+#else
Review comment:
> (nitpick) is this actually possible to happen? how about using `elif` statement explicitly check the configuration?
`else` means default setting. In Kconfig, I configure v1.0A as default hardware version. So I not check CONFIG_WIFI_BOARD_IS110B_HARDWARE_VERSION_10A in `else` codes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org