You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/27 21:24:28 UTC

[GitHub] [spark] rdblue edited a comment on issue #28027: [SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)

rdblue edited a comment on issue #28027: [SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2 (WIP)
URL: https://github.com/apache/spark/pull/28027#issuecomment-605320803
 
 
   @HeartSaVioR, this is currently missing tests.
   
   We have this deployed in our internal Spark build and it works fine. In particular, metadata columns are only projected if they are purposely referenced. We haven't observed any problems with them being added by * expansion and we haven't had any issues with the changes to the analyzer.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org