You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Erik van Oosten (JIRA)" <ji...@apache.org> on 2009/12/08 16:46:18 UTC
[jira] Created: (WICKET-2602) Delay display of upload progress bar
Delay display of upload progress bar
------------------------------------
Key: WICKET-2602
URL: https://issues.apache.org/jira/browse/WICKET-2602
Project: Wicket
Issue Type: Improvement
Components: wicket-extensions
Reporter: Erik van Oosten
When the UploadProgressBar is part of a larger form structure where not all submits actually start a file upload, it is disturbing to see the 'upload starting...' message.
The patch will display the upload bar only after 1 second. Presumably a submit without file will be finished by then.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2602) Display upload progress bar only when
a file is selected
Posted by "Erik van Oosten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik van Oosten updated WICKET-2602:
------------------------------------
Summary: Display upload progress bar only when a file is selected (was: Do not display upload progress bar when no file is selected)
> Display upload progress bar only when a file is selected
> --------------------------------------------------------
>
> Key: WICKET-2602
> URL: https://issues.apache.org/jira/browse/WICKET-2602
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Erik van Oosten
> Attachments: WICKET-2602-1.3.patch, WICKET-2602-1.4_and_1.5.patch
>
>
> When the UploadProgressBar is part of a larger form structure where not all submits actually start a file upload, it is disturbing to see the 'upload starting...' message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2602) Delay display of upload progress bar
Posted by "Erik van Oosten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik van Oosten updated WICKET-2602:
------------------------------------
Comment: was deleted
(was: An even better fix would show the upload bar only when there is a file to upload.)
> Delay display of upload progress bar
> ------------------------------------
>
> Key: WICKET-2602
> URL: https://issues.apache.org/jira/browse/WICKET-2602
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Erik van Oosten
>
> When the UploadProgressBar is part of a larger form structure where not all submits actually start a file upload, it is disturbing to see the 'upload starting...' message.
> The patch will display the upload bar only after 1 second. Presumably a submit without file will be finished by then.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2602) Delay display of upload progress
bar
Posted by "Erik van Oosten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787976#action_12787976 ]
Erik van Oosten commented on WICKET-2602:
-----------------------------------------
I deleted the patch as I have a new patch in the making that will detect if a file will actually be uploaded for a specific file field.
> Delay display of upload progress bar
> ------------------------------------
>
> Key: WICKET-2602
> URL: https://issues.apache.org/jira/browse/WICKET-2602
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Erik van Oosten
>
> When the UploadProgressBar is part of a larger form structure where not all submits actually start a file upload, it is disturbing to see the 'upload starting...' message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2602) Delay display of upload progress bar
Posted by "Erik van Oosten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik van Oosten updated WICKET-2602:
------------------------------------
Comment: was deleted
(was: Please apply this patch to:
- trunk
- branch 1.4.x
- branch 1.3.x)
> Delay display of upload progress bar
> ------------------------------------
>
> Key: WICKET-2602
> URL: https://issues.apache.org/jira/browse/WICKET-2602
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Erik van Oosten
>
> When the UploadProgressBar is part of a larger form structure where not all submits actually start a file upload, it is disturbing to see the 'upload starting...' message.
> The patch will display the upload bar only after 1 second. Presumably a submit without file will be finished by then.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2602) Display upload progress bar only when
a file is selected
Posted by "Erik van Oosten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik van Oosten updated WICKET-2602:
------------------------------------
Attachment: Serialization_optimization_.patch
> Display upload progress bar only when a file is selected
> --------------------------------------------------------
>
> Key: WICKET-2602
> URL: https://issues.apache.org/jira/browse/WICKET-2602
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Erik van Oosten
> Assignee: Igor Vaynberg
> Fix For: 1.4.5, 1.5-M1
>
> Attachments: Serialization_optimization_.patch, WICKET-2602-1.3.patch, WICKET-2602-1.4_and_1.5.patch
>
>
> When the UploadProgressBar is part of a larger form structure where not all submits actually start a file upload, it is disturbing to see the 'upload starting...' message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2602) Do not display upload progress bar
when no file is selected
Posted by "Erik van Oosten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788023#action_12788023 ]
Erik van Oosten commented on WICKET-2602:
-----------------------------------------
Tested the patch with Chrome 3.0 (Windows), IE 8.0 and Firefox 3.5 (Ubuntu).
> Do not display upload progress bar when no file is selected
> -----------------------------------------------------------
>
> Key: WICKET-2602
> URL: https://issues.apache.org/jira/browse/WICKET-2602
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Erik van Oosten
> Attachments: WICKET-2602-1.3.patch, WICKET-2602-1.4_and_1.5.patch
>
>
> When the UploadProgressBar is part of a larger form structure where not all submits actually start a file upload, it is disturbing to see the 'upload starting...' message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2602) Delay display of upload progress bar
Posted by "Erik van Oosten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik van Oosten updated WICKET-2602:
------------------------------------
Description: When the UploadProgressBar is part of a larger form structure where not all submits actually start a file upload, it is disturbing to see the 'upload starting...' message. (was: When the UploadProgressBar is part of a larger form structure where not all submits actually start a file upload, it is disturbing to see the 'upload starting...' message.
The patch will display the upload bar only after 1 second. Presumably a submit without file will be finished by then.)
> Delay display of upload progress bar
> ------------------------------------
>
> Key: WICKET-2602
> URL: https://issues.apache.org/jira/browse/WICKET-2602
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Erik van Oosten
>
> When the UploadProgressBar is part of a larger form structure where not all submits actually start a file upload, it is disturbing to see the 'upload starting...' message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2602) Delay display of upload progress bar
Posted by "Erik van Oosten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik van Oosten updated WICKET-2602:
------------------------------------
Attachment: WICKET-2602.patch
Please apply this patch to:
- trunk
- branch 1.4.x
- branch 1.3.x
> Delay display of upload progress bar
> ------------------------------------
>
> Key: WICKET-2602
> URL: https://issues.apache.org/jira/browse/WICKET-2602
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Erik van Oosten
> Attachments: WICKET-2602.patch
>
>
> When the UploadProgressBar is part of a larger form structure where not all submits actually start a file upload, it is disturbing to see the 'upload starting...' message.
> The patch will display the upload bar only after 1 second. Presumably a submit without file will be finished by then.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (WICKET-2602) Display upload progress bar only
when a file is selected
Posted by "Erik van Oosten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik van Oosten reopened WICKET-2602:
-------------------------------------
Pleas apply attached patch to optimize serialization.
> Display upload progress bar only when a file is selected
> --------------------------------------------------------
>
> Key: WICKET-2602
> URL: https://issues.apache.org/jira/browse/WICKET-2602
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Erik van Oosten
> Assignee: Igor Vaynberg
> Fix For: 1.4.5, 1.5-M1
>
> Attachments: Serialization_optimization_.patch, WICKET-2602-1.3.patch, WICKET-2602-1.4_and_1.5.patch
>
>
> When the UploadProgressBar is part of a larger form structure where not all submits actually start a file upload, it is disturbing to see the 'upload starting...' message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2602) Delay display of upload progress
bar
Posted by "Erik van Oosten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787513#action_12787513 ]
Erik van Oosten commented on WICKET-2602:
-----------------------------------------
An even better fix would show the upload bar only when there is a file to upload.
> Delay display of upload progress bar
> ------------------------------------
>
> Key: WICKET-2602
> URL: https://issues.apache.org/jira/browse/WICKET-2602
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Erik van Oosten
> Attachments: WICKET-2602.patch
>
>
> When the UploadProgressBar is part of a larger form structure where not all submits actually start a file upload, it is disturbing to see the 'upload starting...' message.
> The patch will display the upload bar only after 1 second. Presumably a submit without file will be finished by then.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2602) Display upload progress bar only
when a file is selected
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-2602.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.5-M1
1.4.5
Assignee: Igor Vaynberg
> Display upload progress bar only when a file is selected
> --------------------------------------------------------
>
> Key: WICKET-2602
> URL: https://issues.apache.org/jira/browse/WICKET-2602
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Erik van Oosten
> Assignee: Igor Vaynberg
> Fix For: 1.4.5, 1.5-M1
>
> Attachments: WICKET-2602-1.3.patch, WICKET-2602-1.4_and_1.5.patch
>
>
> When the UploadProgressBar is part of a larger form structure where not all submits actually start a file upload, it is disturbing to see the 'upload starting...' message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2602) Delay display of upload progress bar
Posted by "Erik van Oosten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik van Oosten updated WICKET-2602:
------------------------------------
Attachment: WICKET-2602-1.4_and_1.5.patch
WICKET-2602-1.3.patch
These patches add the option to make UploadProgressBar only display the progress upload bar when a file is selected.
Please apply the 1.3 patch in branch 1.3.x.
Please apply the 1.4_and_1.5 patch in trunk and branch 1.4.x.
> Delay display of upload progress bar
> ------------------------------------
>
> Key: WICKET-2602
> URL: https://issues.apache.org/jira/browse/WICKET-2602
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Erik van Oosten
> Attachments: WICKET-2602-1.3.patch, WICKET-2602-1.4_and_1.5.patch
>
>
> When the UploadProgressBar is part of a larger form structure where not all submits actually start a file upload, it is disturbing to see the 'upload starting...' message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2602) Delay display of upload progress bar
Posted by "Erik van Oosten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik van Oosten updated WICKET-2602:
------------------------------------
Attachment: (was: WICKET-2602.patch)
> Delay display of upload progress bar
> ------------------------------------
>
> Key: WICKET-2602
> URL: https://issues.apache.org/jira/browse/WICKET-2602
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Erik van Oosten
>
> When the UploadProgressBar is part of a larger form structure where not all submits actually start a file upload, it is disturbing to see the 'upload starting...' message.
> The patch will display the upload bar only after 1 second. Presumably a submit without file will be finished by then.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2602) Do not display upload progress bar
when no file is selected
Posted by "Erik van Oosten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik van Oosten updated WICKET-2602:
------------------------------------
Summary: Do not display upload progress bar when no file is selected (was: Delay display of upload progress bar)
> Do not display upload progress bar when no file is selected
> -----------------------------------------------------------
>
> Key: WICKET-2602
> URL: https://issues.apache.org/jira/browse/WICKET-2602
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Erik van Oosten
> Attachments: WICKET-2602-1.3.patch, WICKET-2602-1.4_and_1.5.patch
>
>
> When the UploadProgressBar is part of a larger form structure where not all submits actually start a file upload, it is disturbing to see the 'upload starting...' message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2602) Display upload progress bar only
when a file is selected
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-2602.
-----------------------------------
Resolution: Fixed
> Display upload progress bar only when a file is selected
> --------------------------------------------------------
>
> Key: WICKET-2602
> URL: https://issues.apache.org/jira/browse/WICKET-2602
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Erik van Oosten
> Assignee: Igor Vaynberg
> Fix For: 1.4.5, 1.5-M1
>
> Attachments: Serialization_optimization_.patch, WICKET-2602-1.3.patch, WICKET-2602-1.4_and_1.5.patch
>
>
> When the UploadProgressBar is part of a larger form structure where not all submits actually start a file upload, it is disturbing to see the 'upload starting...' message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2602) Do not display upload progress bar
when no file is selected
Posted by "Erik van Oosten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik van Oosten updated WICKET-2602:
------------------------------------
Comment: was deleted
(was: I deleted the patch as I have a new patch in the making that will detect if a file will actually be uploaded for a specific file field.)
> Do not display upload progress bar when no file is selected
> -----------------------------------------------------------
>
> Key: WICKET-2602
> URL: https://issues.apache.org/jira/browse/WICKET-2602
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Erik van Oosten
> Attachments: WICKET-2602-1.3.patch, WICKET-2602-1.4_and_1.5.patch
>
>
> When the UploadProgressBar is part of a larger form structure where not all submits actually start a file upload, it is disturbing to see the 'upload starting...' message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.