[GitHub] [druid] FrankChen021 commented on a diff in pull request #13165: Druid Catalog basics

[GitBox <gi...@apache.org>]

FrankChen021 commented on code in PR #13165:
URL: https://github.com/apache/druid/pull/13165#discussion_r1000591711


##########
core/src/main/java/org/apache/druid/data/input/InputFormat.java:
##########
@@ -41,15 +41,17 @@
  * See {@link NestedInputFormat} for nested input formats such as JSON.
  */
 @UnstableApi
-@JsonTypeInfo(use = JsonTypeInfo.Id.NAME, property = "type")
+@JsonTypeInfo(use = JsonTypeInfo.Id.NAME, property = InputFormat.TYPE_PROPERTY)
 @JsonSubTypes(value = {
-    @Type(name = "csv", value = CsvInputFormat.class),
-    @Type(name = "json", value = JsonInputFormat.class),
+    @Type(name = CsvInputFormat.TYPE_KEY, value = CsvInputFormat.class),
+    @Type(name = JsonInputFormat.TYPE_KEY, value = JsonInputFormat.class),
     @Type(name = "regex", value = RegexInputFormat.class),

Review Comment:
   Since other string constants are turned into a static constant in each class, why does this one leave unchanged?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org