You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@allura.apache.org by Dave Brondsema <da...@brondsema.net> on 2015/06/01 17:58:49 UTC

[allura:tickets] #6057 Adding an external link should be one step, not two



---

** [tickets:#6057] Adding an external link should be one step, not two**

**Status:** open
**Milestone:** unreleased
**Labels:** ux sf-current sf-4 
**Created:** Fri Apr 05, 2013 02:18 PM UTC by Rich Bowen
**Last Updated:** Tue Mar 10, 2015 09:32 PM UTC
**Owner:** nobody

The process of adding a link (described at http://sourceforge.net/blog/linking-to-resources-hosted-elsewhere/) is unintuitive. I have to add the tool, with a label and mount point, and then I have to scroll down, click "Options" on the tool, and set the link address. This is unintuitive, particularly given that the first dialog says "link" in the Mount Point entry field, implying that I should put the link (URL) there.

Can we make this one step instead of two?



---

Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] Ticket 6057 discussion

Posted by Igor Bondarenko <je...@gmail.com>.

- **status**: in-progress --> review
- **Comment**:

Closed #788 `ib/6057`

Ok, now every tool can expose some of own options to installation dialog via `Application.config_on_install`

I've also added ability to specify `validator` in `ConfigOption` and implemented validation for both "install" and "config" paths based on that.

There are a lot of custom validation for other tools in subclasses of default app admin controller, I didn't touch them, since it's out of scope of this ticket.

There's some room for improvement here. E.g. implementing validation via ajax and displaying errors next to field. This should be pretty straightforward for "config" path, "install" will require a bit of refactoring, I guess. Perhaps we can create a ticket for that.

---

** [tickets:#6057] Adding an external link should be one step, not two**

**Status:** review
**Milestone:** unreleased
**Labels:** sf-4 42cc ux sf-current
**Created:** Fri Apr 05, 2013 02:18 PM UTC by Rich Bowen
**Last Updated:** Tue Jun 02, 2015 08:36 AM UTC
**Owner:** Igor Bondarenko

The process of adding a link (described at http://sourceforge.net/blog/linking-to-resources-hosted-elsewhere/) is unintuitive. I have to add the tool, with a label and mount point, and then I have to scroll down, click "Options" on the tool, and set the link address. This is unintuitive, particularly given that the first dialog says "link" in the Mount Point entry field, implying that I should put the link (URL) there.

Can we make this one step instead of two?

---

Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] Ticket 6057 discussion

Posted by Heith Seewald <hs...@slashdotmedia.com>.

- **status**: review --> in-progress
- **Comment**:

Looking great Igor!

What do you think about having the ability to pass 'help text' and maybe a 'verbose name' to give more context about the config option?

For example, I tried adding an install option for disabling one-click urls. Everything worked great, but the name of the option showed up as **disable_merge**.

Another example would be the new **Url** option in the **External Link** tool could be less confusing if it said "External Url" -- or something like that.

Also, and this isn't directly related to this ticket, but the existing help text for the `External Link` creation options is referring to **mount points**, which doesn't match up with the existing fields. Maybe we can change that or get rid of it all together?




---

** [tickets:#6057] Adding an external link should be one step, not two**

**Status:** in-progress
**Milestone:** unreleased
**Labels:** sf-4 42cc ux sf-current 
**Created:** Fri Apr 05, 2013 02:18 PM UTC by Rich Bowen
**Last Updated:** Fri Jun 05, 2015 02:25 PM UTC
**Owner:** Igor Bondarenko

The process of adding a link (described at http://sourceforge.net/blog/linking-to-resources-hosted-elsewhere/) is unintuitive. I have to add the tool, with a label and mount point, and then I have to scroll down, click "Options" on the tool, and set the link address. This is unintuitive, particularly given that the first dialog says "link" in the Mount Point entry field, implying that I should put the link (URL) there.

Can we make this one step instead of two?



---

Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] Ticket 6057 discussion

Posted by Igor Bondarenko <je...@gmail.com>.

- **status**: in-progress --> review
- **Comment**:

Closed #792. Updated `ib/6057`

- ConfigOption can specify `extra_attrs` dict, which will be added to html input attrs and url option uses it to specify type=url
- Added help_text option and code to render it in templates. We already have "label" option, which is used as a verbose name. I've specified it for external url.
- Removed text referring to mount points. I think with our "preview" functionality we don't really need it and removing it makes UI somewhat cleaner.

---

** [tickets:#6057] Adding an external link should be one step, not two**

**Status:** review
**Milestone:** unreleased
**Labels:** sf-4 42cc ux sf-current
**Created:** Fri Apr 05, 2013 02:18 PM UTC by Rich Bowen
**Last Updated:** Fri Jun 05, 2015 05:49 PM UTC
**Owner:** Igor Bondarenko

Can we make this one step instead of two?

---

Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/

[allura:tickets] Ticket 6057 discussion

Posted by Heith Seewald <hs...@slashdotmedia.com>.

- **status**: review --> closed
- **Comment**:

Very nice Igor -- it looks great!



---

** [tickets:#6057] Adding an external link should be one step, not two**

**Status:** closed
**Milestone:** unreleased
**Labels:** sf-4 42cc ux sf-current 
**Created:** Fri Apr 05, 2013 02:18 PM UTC by Rich Bowen
**Last Updated:** Tue Jun 09, 2015 02:34 PM UTC
**Owner:** Igor Bondarenko

The process of adding a link (described at http://sourceforge.net/blog/linking-to-resources-hosted-elsewhere/) is unintuitive. I have to add the tool, with a label and mount point, and then I have to scroll down, click "Options" on the tool, and set the link address. This is unintuitive, particularly given that the first dialog says "link" in the Mount Point entry field, implying that I should put the link (URL) there.

Can we make this one step instead of two?



---

Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] Ticket 6057 discussion

Posted by Dave Brondsema <da...@brondsema.net>.

- **labels**: sf-4, 42cc, ux, sf-current --> sf-4, 42cc, ux



---

** [tickets:#6057] Adding an external link should be one step, not two**

**Status:** closed
**Milestone:** unreleased
**Labels:** sf-4 42cc ux 
**Created:** Fri Apr 05, 2013 02:18 PM UTC by Rich Bowen
**Last Updated:** Tue Jun 09, 2015 09:09 PM UTC
**Owner:** Igor Bondarenko

The process of adding a link (described at http://sourceforge.net/blog/linking-to-resources-hosted-elsewhere/) is unintuitive. I have to add the tool, with a label and mount point, and then I have to scroll down, click "Options" on the tool, and set the link address. This is unintuitive, particularly given that the first dialog says "link" in the Mount Point entry field, implying that I should put the link (URL) there.

Can we make this one step instead of two?



---

Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] Ticket 6057 discussion

Posted by Heith Seewald <hs...@slashdotmedia.com>.

- **Reviewer**: Heith Seewald



---

** [tickets:#6057] Adding an external link should be one step, not two**

**Status:** review
**Milestone:** unreleased
**Labels:** sf-4 42cc ux sf-current 
**Created:** Fri Apr 05, 2013 02:18 PM UTC by Rich Bowen
**Last Updated:** Fri Jun 05, 2015 01:20 PM UTC
**Owner:** Igor Bondarenko

The process of adding a link (described at http://sourceforge.net/blog/linking-to-resources-hosted-elsewhere/) is unintuitive. I have to add the tool, with a label and mount point, and then I have to scroll down, click "Options" on the tool, and set the link address. This is unintuitive, particularly given that the first dialog says "link" in the Mount Point entry field, implying that I should put the link (URL) there.

Can we make this one step instead of two?



---

Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] Ticket 6057 discussion

Posted by Dave Brondsema <da...@brondsema.net>.

- **labels**: ux --> ux, sf-current, sf-4



---

** [tickets:#6057] Adding an external link should be one step, not two**

**Status:** open
**Milestone:** unreleased
**Labels:** ux sf-current sf-4 
**Created:** Fri Apr 05, 2013 02:18 PM UTC by Rich Bowen
**Last Updated:** Tue Mar 10, 2015 09:32 PM UTC
**Owner:** nobody

The process of adding a link (described at http://sourceforge.net/blog/linking-to-resources-hosted-elsewhere/) is unintuitive. I have to add the tool, with a label and mount point, and then I have to scroll down, click "Options" on the tool, and set the link address. This is unintuitive, particularly given that the first dialog says "link" in the Mount Point entry field, implying that I should put the link (URL) there.

Can we make this one step instead of two?



---

Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] Re: Ticket 6057 discussion

Posted by Dave Brondsema <da...@brondsema.net>.

And is it possible to make the URL field be `type=url`?  That would help without requiring any validation setup on our part.


---

** [tickets:#6057] Adding an external link should be one step, not two**

**Status:** in-progress
**Milestone:** unreleased
**Labels:** sf-4 42cc ux sf-current 
**Created:** Fri Apr 05, 2013 02:18 PM UTC by Rich Bowen
**Last Updated:** Fri Jun 05, 2015 05:49 PM UTC
**Owner:** Igor Bondarenko

The process of adding a link (described at http://sourceforge.net/blog/linking-to-resources-hosted-elsewhere/) is unintuitive. I have to add the tool, with a label and mount point, and then I have to scroll down, click "Options" on the tool, and set the link address. This is unintuitive, particularly given that the first dialog says "link" in the Mount Point entry field, implying that I should put the link (URL) there.

Can we make this one step instead of two?



---

Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.