You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/07 13:18:04 UTC

[GitHub] [incubator-shardingsphere] terrymanu opened a new issue #4645: Use YAML configuration instead of java configuration for AbstractEncryptJDBCDatabaseAndTableTest

terrymanu opened a new issue #4645: Use YAML configuration instead of java configuration for AbstractEncryptJDBCDatabaseAndTableTest
URL: https://github.com/apache/incubator-shardingsphere/issues/4645
 
 
   YAML configuration is clear and easy to understand. 
   Using YAML configuration to instead of java configuration for AbstractEncryptJDBCDatabaseAndTableTest is better.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] ranjeet-floyd commented on issue #4645: Use YAML configuration instead of java configuration for DataSource test

Posted by GitBox <gi...@apache.org>.
ranjeet-floyd commented on issue #4645: Use YAML configuration instead of java configuration for DataSource test
URL: https://github.com/apache/incubator-shardingsphere/issues/4645#issuecomment-597407746
 
 
   @terrymanu  Can i take this ?. Thanks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4645: Use YAML configuration instead of java configuration for DataSource test

Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #4645: Use YAML configuration instead of java configuration for DataSource test
URL: https://github.com/apache/incubator-shardingsphere/issues/4645#issuecomment-599372292
 
 
   @ranjeet-floyd there are 3 sub-tasks, you can take the last one if you interest.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu closed issue #4645: Use YAML configuration instead of java configuration for DataSource test

Posted by GitBox <gi...@apache.org>.
terrymanu closed issue #4645: Use YAML configuration instead of java configuration for DataSource test
URL: https://github.com/apache/incubator-shardingsphere/issues/4645
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] ranjeet-floyd edited a comment on issue #4645: Use YAML configuration instead of java configuration for DataSource test

Posted by GitBox <gi...@apache.org>.
ranjeet-floyd edited a comment on issue #4645: Use YAML configuration instead of java configuration for DataSource test
URL: https://github.com/apache/incubator-shardingsphere/issues/4645#issuecomment-601853603
 
 
   @terrymanu Raised PR for AbstractEncryptJDBCDatabaseAndTableTest.  https://github.com/apache/incubator-shardingsphere/pull/4871
   
   Please let me if this is right way , then  will do others.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] HetaoWang commented on issue #4645: Use YAML configuration instead of java configuration for DataSource test

Posted by GitBox <gi...@apache.org>.
HetaoWang commented on issue #4645: Use YAML configuration instead of java configuration for DataSource test
URL: https://github.com/apache/incubator-shardingsphere/issues/4645#issuecomment-596176876
 
 
   I want to do it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4645: Use YAML configuration instead of java configuration for DataSource test

Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #4645: Use YAML configuration instead of java configuration for DataSource test
URL: https://github.com/apache/incubator-shardingsphere/issues/4645#issuecomment-596179807
 
 
   @HetaoWang Welcome on board.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #4645: Use YAML configuration instead of java configuration for DataSource test

Posted by GitBox <gi...@apache.org>.
terrymanu edited a comment on issue #4645: Use YAML configuration instead of java configuration for DataSource test
URL: https://github.com/apache/incubator-shardingsphere/issues/4645#issuecomment-599372292
 
 
   @ranjeet-floyd there are 3 sub-tasks, you may take the last one if you interest.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] ranjeet-floyd commented on issue #4645: Use YAML configuration instead of java configuration for DataSource test

Posted by GitBox <gi...@apache.org>.
ranjeet-floyd commented on issue #4645: Use YAML configuration instead of java configuration for DataSource test
URL: https://github.com/apache/incubator-shardingsphere/issues/4645#issuecomment-599650810
 
 
   @terrymanu  ok  i will take   `AbstractShardingJDBCDatabaseAndTableTest for sahrding rule creation` Thanks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] ranjeet-floyd commented on issue #4645: Use YAML configuration instead of java configuration for DataSource test

Posted by GitBox <gi...@apache.org>.
ranjeet-floyd commented on issue #4645: Use YAML configuration instead of java configuration for DataSource test
URL: https://github.com/apache/incubator-shardingsphere/issues/4645#issuecomment-601853603
 
 
   @terrymanu Raised PR for AbstractEncryptJDBCDatabaseAndTableTest.  https://github.com/apache/incubator-shardingsphere/pull/4871
   
   Please let me if this is right way , then can will do others.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services