You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "dan-s1 (via GitHub)" <gi...@apache.org> on 2026/03/27 21:12:03 UTC

[PR] NIFI-14205 Enhanced the AWS components by listing the AWS Regions in case insensitive alphabetical order. [nifi]

dan-s1 opened a new pull request, #11066:
URL: https://github.com/apache/nifi/pull/11066

   <!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
   <!-- contributor license agreements.  See the NOTICE file distributed with -->
   <!-- this work for additional information regarding copyright ownership. -->
   <!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
   <!-- (the "License"); you may not use this file except in compliance with -->
   <!-- the License.  You may obtain a copy of the License at -->
   <!--     http://www.apache.org/licenses/LICENSE-2.0 -->
   <!-- Unless required by applicable law or agreed to in writing, software -->
   <!-- distributed under the License is distributed on an "AS IS" BASIS, -->
   <!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
   <!-- See the License for the specific language governing permissions and -->
   <!-- limitations under the License. -->
   
   # Summary
   
   [NIFI-14205](https://issues.apache.org/jira/browse/NIFI-14205)
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   - [ ] Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status
   
   ### Pull Request Formatting
   
   - [ ] Pull Request based on current revision of the `main` branch
   - [ ] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [ ] Build completed using `./mvnw clean install -P contrib-check`
     - [ ] JDK 21
     - [ ] JDK 25
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-14205 Enhanced the AWS components by listing the AWS Regions in case insensitive alphabetical order. [nifi]

Posted by "dan-s1 (via GitHub)" <gi...@apache.org>.
dan-s1 commented on code in PR #11066:
URL: https://github.com/apache/nifi/pull/11066#discussion_r3010099440


##########
nifi-extension-bundles/nifi-aws-bundle/nifi-aws-regions/src/test/java/org/apache/nifi/processors/aws/region/RegionUtilTest.java:
##########
@@ -106,4 +108,12 @@ void testIsDynamicRegionWithDynamicCustomRegion() {
 
         assertTrue(RegionUtil.isDynamicRegion(propertyContext));
     }
+
+    @Test
+    void testRegionDisplayNameOrdering() {
+        final List<AllowableValue> allowableRegionValues = REGION.getAllowableValues();
+
+        assertEquals("Africa (Cape Town)", allowableRegionValues.getFirst().getDisplayName());

Review Comment:
   @pvillard31 Should I post the screenshots to this PR or the ticket?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-14205 Enhanced the AWS components by listing the AWS Regions in case insensitive alphabetical order. [nifi]

Posted by "pvillard31 (via GitHub)" <gi...@apache.org>.
pvillard31 commented on code in PR #11066:
URL: https://github.com/apache/nifi/pull/11066#discussion_r3005053575


##########
nifi-extension-bundles/nifi-aws-bundle/nifi-aws-regions/src/test/java/org/apache/nifi/processors/aws/region/RegionUtilTest.java:
##########
@@ -106,4 +108,12 @@ void testIsDynamicRegionWithDynamicCustomRegion() {
 
         assertTrue(RegionUtil.isDynamicRegion(propertyContext));
     }
+
+    @Test
+    void testRegionDisplayNameOrdering() {
+        final List<AllowableValue> allowableRegionValues = REGION.getAllowableValues();
+
+        assertEquals("Africa (Cape Town)", allowableRegionValues.getFirst().getDisplayName());

Review Comment:
   I agree this is unlikely but this test might fail when we upgrade the dependency in AWS SDK and they add a new region. Honestly, I'm fine without a unit test for this change. If you can share a screenshot of the before/after in the UI that's good enough with me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-14205 Enhanced the AWS components by listing the AWS Regions in case insensitive alphabetical order. [nifi]

Posted by "pvillard31 (via GitHub)" <gi...@apache.org>.
pvillard31 merged PR #11066:
URL: https://github.com/apache/nifi/pull/11066


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-14205 Enhanced the AWS components by listing the AWS Regions in case insensitive alphabetical order. [nifi]

Posted by "dan-s1 (via GitHub)" <gi...@apache.org>.
dan-s1 commented on code in PR #11066:
URL: https://github.com/apache/nifi/pull/11066#discussion_r3010318437


##########
nifi-extension-bundles/nifi-aws-bundle/nifi-aws-regions/src/test/java/org/apache/nifi/processors/aws/region/RegionUtilTest.java:
##########
@@ -106,4 +108,12 @@ void testIsDynamicRegionWithDynamicCustomRegion() {
 
         assertTrue(RegionUtil.isDynamicRegion(propertyContext));
     }
+
+    @Test
+    void testRegionDisplayNameOrdering() {
+        final List<AllowableValue> allowableRegionValues = REGION.getAllowableValues();
+
+        assertEquals("Africa (Cape Town)", allowableRegionValues.getFirst().getDisplayName());

Review Comment:
   @pvillard31 I attached them to the summary and I removed the unit test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-14205 Enhanced the AWS components by listing the AWS Regions in case insensitive alphabetical order. [nifi]

Posted by "pvillard31 (via GitHub)" <gi...@apache.org>.
pvillard31 commented on code in PR #11066:
URL: https://github.com/apache/nifi/pull/11066#discussion_r3010130750


##########
nifi-extension-bundles/nifi-aws-bundle/nifi-aws-regions/src/test/java/org/apache/nifi/processors/aws/region/RegionUtilTest.java:
##########
@@ -106,4 +108,12 @@ void testIsDynamicRegionWithDynamicCustomRegion() {
 
         assertTrue(RegionUtil.isDynamicRegion(propertyContext));
     }
+
+    @Test
+    void testRegionDisplayNameOrdering() {
+        final List<AllowableValue> allowableRegionValues = REGION.getAllowableValues();
+
+        assertEquals("Africa (Cape Town)", allowableRegionValues.getFirst().getDisplayName());

Review Comment:
   either is fine with me



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org