You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/09/12 01:55:26 UTC

[GitHub] [helix] kaisun2000 commented on pull request #1328: Enhance ZkHelixVerifier and its related subclass to take a default wait period

kaisun2000 commented on pull request #1328:
URL: https://github.com/apache/helix/pull/1328#issuecomment-691380665


   This diff is approved, please help to merge.
   
   > Due to #526, currently we have random sleep() in the test before verifyByPolling().
   This cause test failure in different environment. Here we enhance ZKHelixVerifier
   family with an option in builder to add a waiting period. To keep it backward
   compatible, without enable this waiting option, the code would behave exactly the
   same as before.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org