You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by tg...@apache.org on 2017/05/22 16:59:35 UTC
[2/2] beam git commit: Fix GroupAlsoByWindowEvaluatorFactory doc
Fix GroupAlsoByWindowEvaluatorFactory doc
Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/a7ad0c2b
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/a7ad0c2b
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/a7ad0c2b
Branch: refs/heads/master
Commit: a7ad0c2b06df5fc281eb91f73053396a61b11f53
Parents: 6a68e65
Author: Thomas Groh <tg...@google.com>
Authored: Thu May 18 09:09:33 2017 -0700
Committer: Thomas Groh <tg...@google.com>
Committed: Mon May 22 09:59:23 2017 -0700
----------------------------------------------------------------------
.../direct/GroupAlsoByWindowEvaluatorFactory.java | 18 ++++++++++--------
1 file changed, 10 insertions(+), 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/beam/blob/a7ad0c2b/runners/direct-java/src/main/java/org/apache/beam/runners/direct/GroupAlsoByWindowEvaluatorFactory.java
----------------------------------------------------------------------
diff --git a/runners/direct-java/src/main/java/org/apache/beam/runners/direct/GroupAlsoByWindowEvaluatorFactory.java b/runners/direct-java/src/main/java/org/apache/beam/runners/direct/GroupAlsoByWindowEvaluatorFactory.java
index 84be15d..78ef7fe 100644
--- a/runners/direct-java/src/main/java/org/apache/beam/runners/direct/GroupAlsoByWindowEvaluatorFactory.java
+++ b/runners/direct-java/src/main/java/org/apache/beam/runners/direct/GroupAlsoByWindowEvaluatorFactory.java
@@ -26,8 +26,6 @@ import java.util.ArrayList;
import java.util.Collection;
import org.apache.beam.runners.core.GroupAlsoByWindowsAggregators;
import org.apache.beam.runners.core.GroupByKeyViaGroupByKeyOnly;
-import org.apache.beam.runners.core.GroupByKeyViaGroupByKeyOnly.GroupAlsoByWindow;
-import org.apache.beam.runners.core.GroupByKeyViaGroupByKeyOnly.GroupByKeyOnly;
import org.apache.beam.runners.core.KeyedWorkItem;
import org.apache.beam.runners.core.OutputWindowedValue;
import org.apache.beam.runners.core.ReduceFnRunner;
@@ -57,7 +55,7 @@ import org.joda.time.Instant;
/**
* The {@link DirectRunner} {@link TransformEvaluatorFactory} for the
- * {@link GroupByKeyOnly} {@link PTransform}.
+ * {@link DirectGroupAlsoByWindow} {@link PTransform}.
*/
class GroupAlsoByWindowEvaluatorFactory implements TransformEvaluatorFactory {
private final EvaluationContext evaluationContext;
@@ -92,8 +90,9 @@ class GroupAlsoByWindowEvaluatorFactory implements TransformEvaluatorFactory {
}
/**
- * A transform evaluator for the pseudo-primitive {@link GroupAlsoByWindow}. Windowing is ignored;
- * all input should be in the global window since all output will be as well.
+ * A transform evaluator for the pseudo-primitive {@link DirectGroupAlsoByWindow}. The window of
+ * the input {@link KeyedWorkItem} is ignored; it should be in the global window, as element
+ * windows are reified in the {@link KeyedWorkItem#elementsIterable()}.
*
* @see GroupByKeyViaGroupByKeyOnly
*/
@@ -173,7 +172,7 @@ class GroupAlsoByWindowEvaluatorFactory implements TransformEvaluatorFactory {
stateInternals,
timerInternals,
new OutputWindowedValueToBundle<>(bundle),
- new UnsupportedSideInputReader("GroupAlsoByWindow"),
+ new UnsupportedSideInputReader(DirectGroupAlsoByWindow.class.getSimpleName()),
reduceFn,
evaluationContext.getPipelineOptions());
@@ -226,8 +225,9 @@ class GroupAlsoByWindowEvaluatorFactory implements TransformEvaluatorFactory {
// The element is too late for this window.
droppedDueToLateness.inc();
WindowTracing.debug(
- "GroupAlsoByWindow: Dropping element at {} for key: {}; "
+ "{}: Dropping element at {} for key: {}; "
+ "window: {} since it is too far behind inputWatermark: {}",
+ DirectGroupAlsoByWindow.class.getSimpleName(),
input.getTimestamp(),
key,
window,
@@ -264,7 +264,9 @@ class GroupAlsoByWindowEvaluatorFactory implements TransformEvaluatorFactory {
Instant timestamp,
Collection<? extends BoundedWindow> windows,
PaneInfo pane) {
- throw new UnsupportedOperationException("GroupAlsoByWindow should not use tagged outputs");
+ throw new UnsupportedOperationException(
+ String.format(
+ "%s should not use tagged outputs", DirectGroupAlsoByWindow.class.getSimpleName()));
}
}
}