You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by sanjeev n <sa...@citrix.com> on 2013/04/30 13:51:26 UTC
Review Request: CLOUDSTACK-702: Tests for Multiple IP Ranges
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10861/
-----------------------------------------------------------
Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao Talluri.
Description
-------
CLOUDSTACK-702: Tests for Multiple IP Ranges
1. Deleting IP Range from the existing CIDR.
This addresses bug CLOUDSTACK-702.
Diffs
-----
test/integration/component/test_multiple_ip_ranges.py 489e7ca
Diff: https://reviews.apache.org/r/10861/diff/
Testing
-------
Tested with fixed IP addresses since code has not been implemented(To make sure no syntax errors).
Thanks,
sanjeev n
Re: Review Request: CLOUDSTACK-702: Tests for Multiple IP Ranges
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10861/#review20183
-----------------------------------------------------------
Ship it!
commit 834c11af1c40d305cf5b2c44f48d192863aa26cb
Author: sanjeevneelarapu <sa...@citrix.com>
Date: Tue Apr 30 20:09:46 2013 +0530
CLOUDSTACK-702: Tests for Multiple IP Ranges
1.Deleting IP Range from the existing CIDR
2.Add non-contiguous guest IP range in new CIDR
3.Add overlapped guest IP range in existing CIDR
Signed-off-by: sanjeevneelarapu <sa...@citrix.com>
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
- Prasanna Santhanam
On May 2, 2013, 12:04 p.m., sanjeev n wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10861/
> -----------------------------------------------------------
>
> (Updated May 2, 2013, 12:04 p.m.)
>
>
> Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao Talluri.
>
>
> Description
> -------
>
> CLOUDSTACK-702: Tests for Multiple IP Ranges
>
> 1. Deleting IP Range from the existing CIDR.
>
>
> This addresses bug CLOUDSTACK-702.
>
>
> Diffs
> -----
>
> test/integration/component/test_multiple_ip_ranges.py 489e7ca
>
> Diff: https://reviews.apache.org/r/10861/diff/
>
>
> Testing
> -------
>
> Tested with fixed IP addresses since code has not been implemented(To make sure no syntax errors).
>
>
> Thanks,
>
> sanjeev n
>
>
RE: Review Request: CLOUDSTACK-702: Tests for Multiple IP Ranges
Posted by Sanjeev Neelarapu <sa...@citrix.com>.
Prasanna,
This request has two patches: revision1 and revision2
In my local branch(which is up-to-date with master) I applied revision1 first and then revision2.
I think you are trying to apply revision2 which has only differences from revision1.
Can you try applying revision1 first and 2 later?
Thanks,
Sanjeev
-----Original Message-----
From: Prasanna Santhanam [mailto:noreply@reviews.apache.org] On Behalf Of Prasanna Santhanam
Sent: Monday, May 06, 2013 12:19 PM
To: Prasanna Santhanam; Srikanteswararao Talluri
Cc: cloudstack; Sanjeev Neelarapu
Subject: Re: Review Request: CLOUDSTACK-702: Tests for Multiple IP Ranges
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10861/#review20178
-----------------------------------------------------------
This looks fine but I'm unable to apply your patch onto master. Can you resubmit please? Thanks
~/workspace/cloudstack/incubator-cloudstack(branch:master) » git am -s patch/0001-CLOUDSTACK-702-Test-for-Multiple-IP-Ranges-R3.patch tsp@cloud-2
Applying: CLOUDSTACK-702: Test for Multiple IP Ranges-R3 1.Add non-contiguous guest IP range in new CIDR 2.Add overlapped guest IP range in existing CIDR
fatal: corrupt patch at line 187
Patch failed at 0001 CLOUDSTACK-702: Test for Multiple IP Ranges-R3 1.Add non-contiguous guest IP range in new CIDR 2.Add overlapped guest IP range in existing CIDR When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".
- Prasanna Santhanam
On May 2, 2013, 12:04 p.m., sanjeev n wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10861/
> -----------------------------------------------------------
>
> (Updated May 2, 2013, 12:04 p.m.)
>
>
> Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao Talluri.
>
>
> Description
> -------
>
> CLOUDSTACK-702: Tests for Multiple IP Ranges
>
> 1. Deleting IP Range from the existing CIDR.
>
>
> This addresses bug CLOUDSTACK-702.
>
>
> Diffs
> -----
>
> test/integration/component/test_multiple_ip_ranges.py 489e7ca
>
> Diff: https://reviews.apache.org/r/10861/diff/
>
>
> Testing
> -------
>
> Tested with fixed IP addresses since code has not been implemented(To make sure no syntax errors).
>
>
> Thanks,
>
> sanjeev n
>
>
Re: Review Request: CLOUDSTACK-702: Tests for Multiple IP Ranges
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10861/#review20178
-----------------------------------------------------------
This looks fine but I'm unable to apply your patch onto master. Can you resubmit please? Thanks
~/workspace/cloudstack/incubator-cloudstack(branch:master) » git am -s patch/0001-CLOUDSTACK-702-Test-for-Multiple-IP-Ranges-R3.patch tsp@cloud-2
Applying: CLOUDSTACK-702: Test for Multiple IP Ranges-R3 1.Add non-contiguous guest IP range in new CIDR 2.Add overlapped guest IP range in existing CIDR
fatal: corrupt patch at line 187
Patch failed at 0001 CLOUDSTACK-702: Test for Multiple IP Ranges-R3 1.Add non-contiguous guest IP range in new CIDR 2.Add overlapped guest IP range in existing CIDR
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".
- Prasanna Santhanam
On May 2, 2013, 12:04 p.m., sanjeev n wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10861/
> -----------------------------------------------------------
>
> (Updated May 2, 2013, 12:04 p.m.)
>
>
> Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao Talluri.
>
>
> Description
> -------
>
> CLOUDSTACK-702: Tests for Multiple IP Ranges
>
> 1. Deleting IP Range from the existing CIDR.
>
>
> This addresses bug CLOUDSTACK-702.
>
>
> Diffs
> -----
>
> test/integration/component/test_multiple_ip_ranges.py 489e7ca
>
> Diff: https://reviews.apache.org/r/10861/diff/
>
>
> Testing
> -------
>
> Tested with fixed IP addresses since code has not been implemented(To make sure no syntax errors).
>
>
> Thanks,
>
> sanjeev n
>
>
Re: Review Request: CLOUDSTACK-702: Tests for Multiple IP Ranges
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10861/#review20314
-----------------------------------------------------------
Commit 53e496517ed51bab2c81084a02f49b0408b19a37 in branch refs/heads/marvin_refactor from Prasanna Santhanam <ts...@apache.org>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=53e4965 ]
CLOUDSTACK-702: Tests for Multiple IP Ranges-R4
Add ip range overlapped with two ip ranges in the exiting cidr
Signed-off-by: sanjeevneelarapu <sa...@citrix.com>
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
- ASF Subversion and Git Services
On May 2, 2013, 12:04 p.m., sanjeev n wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10861/
> -----------------------------------------------------------
>
> (Updated May 2, 2013, 12:04 p.m.)
>
>
> Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao Talluri.
>
>
> Description
> -------
>
> CLOUDSTACK-702: Tests for Multiple IP Ranges
>
> 1. Deleting IP Range from the existing CIDR.
>
>
> This addresses bug CLOUDSTACK-702.
>
>
> Diffs
> -----
>
> test/integration/component/test_multiple_ip_ranges.py 489e7ca
>
> Diff: https://reviews.apache.org/r/10861/diff/
>
>
> Testing
> -------
>
> Tested with fixed IP addresses since code has not been implemented(To make sure no syntax errors).
>
>
> Thanks,
>
> sanjeev n
>
>
Re: Review Request: CLOUDSTACK-702: Tests for Multiple IP Ranges
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10861/#review20309
-----------------------------------------------------------
Commit 53e496517ed51bab2c81084a02f49b0408b19a37 in branch refs/heads/master from Prasanna Santhanam <ts...@apache.org>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=53e4965 ]
CLOUDSTACK-702: Tests for Multiple IP Ranges-R4
Add ip range overlapped with two ip ranges in the exiting cidr
Signed-off-by: sanjeevneelarapu <sa...@citrix.com>
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
- ASF Subversion and Git Services
On May 2, 2013, 12:04 p.m., sanjeev n wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10861/
> -----------------------------------------------------------
>
> (Updated May 2, 2013, 12:04 p.m.)
>
>
> Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao Talluri.
>
>
> Description
> -------
>
> CLOUDSTACK-702: Tests for Multiple IP Ranges
>
> 1. Deleting IP Range from the existing CIDR.
>
>
> This addresses bug CLOUDSTACK-702.
>
>
> Diffs
> -----
>
> test/integration/component/test_multiple_ip_ranges.py 489e7ca
>
> Diff: https://reviews.apache.org/r/10861/diff/
>
>
> Testing
> -------
>
> Tested with fixed IP addresses since code has not been implemented(To make sure no syntax errors).
>
>
> Thanks,
>
> sanjeev n
>
>
Re: Review Request: CLOUDSTACK-702: Tests for Multiple IP Ranges
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10861/#review20184
-----------------------------------------------------------
Commit 70c936bb852cac885ab20ffc7276515215c08026 in branch refs/heads/master from Prasanna Santhanam <ts...@apache.org>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=70c936bb ]
CLOUDSTACK-702: Tests for Multiple IP Ranges
1.Deleting IP Range from the existing CIDR
2.Add non-contiguous guest IP range in new CIDR
3.Add overlapped guest IP range in existing CIDR
Signed-off-by: sanjeevneelarapu <sa...@citrix.com>
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
- ASF Subversion and Git Services
On May 2, 2013, 12:04 p.m., sanjeev n wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10861/
> -----------------------------------------------------------
>
> (Updated May 2, 2013, 12:04 p.m.)
>
>
> Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao Talluri.
>
>
> Description
> -------
>
> CLOUDSTACK-702: Tests for Multiple IP Ranges
>
> 1. Deleting IP Range from the existing CIDR.
>
>
> This addresses bug CLOUDSTACK-702.
>
>
> Diffs
> -----
>
> test/integration/component/test_multiple_ip_ranges.py 489e7ca
>
> Diff: https://reviews.apache.org/r/10861/diff/
>
>
> Testing
> -------
>
> Tested with fixed IP addresses since code has not been implemented(To make sure no syntax errors).
>
>
> Thanks,
>
> sanjeev n
>
>
Re: Review Request: CLOUDSTACK-702: Tests for Multiple IP Ranges
Posted by sanjeev n <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10861/
-----------------------------------------------------------
(Updated May 2, 2013, 12:04 p.m.)
Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao Talluri.
Changes
-------
Added two more test cases:
1.Add non-contiguous guest IP range in the existing CIDR
2.Add overlapped guest IP range in the existing CIDR
Also corrected few errors in previous tests.
Description
-------
CLOUDSTACK-702: Tests for Multiple IP Ranges
1. Deleting IP Range from the existing CIDR.
This addresses bug CLOUDSTACK-702.
Diffs (updated)
-----
test/integration/component/test_multiple_ip_ranges.py 489e7ca
Diff: https://reviews.apache.org/r/10861/diff/
Testing
-------
Tested with fixed IP addresses since code has not been implemented(To make sure no syntax errors).
Thanks,
sanjeev n