You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/06/16 18:06:16 UTC

[GitHub] [arrow-rs] alamb commented on a diff in pull request #4425: Parse intervals like `.5` the same as `0.5`

alamb commented on code in PR #4425:
URL: https://github.com/apache/arrow-rs/pull/4425#discussion_r1232573299


##########
arrow-cast/src/parse.rs:
##########
@@ -1944,10 +1958,6 @@ mod tests {
 
         assert_eq!(result, expected);
 
-        // invalid: missing integer

Review Comment:
   There was an explicit test against this behavior, which leads me to believe that this may not be something we want to allow (postgres support not withstanding)
   
   Also, since I think this is a corner case without a large likelihood of being hit, it shouldn't block the arrow 42.0.0 release https://github.com/apache/arrow-rs/issues/4422 -- but I will mention it on the release communications



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org