You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/01/11 12:38:04 UTC
[GitHub] [activemq-artemis] franz1981 opened a new pull request #3403: ARTEMIS-3059 AMQP message reencoding should save creating Netty heap arenas
franz1981 opened a new pull request #3403:
URL: https://github.com/apache/activemq-artemis/pull/3403
https://issues.apache.org/jira/browse/ARTEMIS-3059
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit closed pull request #3403: ARTEMIS-3059 AMQP message reencoding should save creating Netty heap arenas
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3403:
URL: https://github.com/apache/activemq-artemis/pull/3403
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] franz1981 edited a comment on pull request #3403: ARTEMIS-3059 AMQP message reencoding should save creating Netty heap arenas
Posted by GitBox <gi...@apache.org>.
franz1981 edited a comment on pull request #3403:
URL: https://github.com/apache/activemq-artemis/pull/3403#issuecomment-757970543
@gemmellr it seems that Netty pooled heap arenas are still allocated, but are empty (that's why they have such small footprint on the screenshot).
This PR is delivering the improvement I was seeking.
> I dont really know much about the brokers pooled netty buffer usages, most of my usage (elsewhere) avoids them. As you say there do look to be others uses besides the one changed here.
I see that `AMQPMessage::createDeliveryCopy` is using it, but probably @clebertsuconic knows about it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on pull request #3403: ARTEMIS-3059 AMQP message reencoding should save creating Netty heap arenas
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3403:
URL: https://github.com/apache/activemq-artemis/pull/3403#issuecomment-757967711
I dont really know much about the brokers pooled netty buffer usages, most of my usage (elsewhere) avoids them. As you say there do look to be others uses besides the one changed here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] franz1981 edited a comment on pull request #3403: ARTEMIS-3059 AMQP message reencoding should save creating Netty heap arenas
Posted by GitBox <gi...@apache.org>.
franz1981 edited a comment on pull request #3403:
URL: https://github.com/apache/activemq-artemis/pull/3403#issuecomment-757945626
It doesn't seem enough to save Netty heap arenas to be allocated, see
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3403: ARTEMIS-3059 AMQP message reencoding should save creating Netty heap arenas
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3403:
URL: https://github.com/apache/activemq-artemis/pull/3403#issuecomment-758061235
@franz1981 we should probably review and manage those PooledBuffers usage as whole?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] franz1981 commented on pull request #3403: ARTEMIS-3059 AMQP message reencoding should save creating Netty heap arenas
Posted by GitBox <gi...@apache.org>.
franz1981 commented on pull request #3403:
URL: https://github.com/apache/activemq-artemis/pull/3403#issuecomment-757970543
@gemmellr it seems that Netty pooled heap arenas are still allocated, but are empty (that's whye they have such small footprint on the screenshot).
This PR is delivering the improvement I was seeking.
> I dont really know much about the brokers pooled netty buffer usages, most of my usage (elsewhere) avoids them. As you say there do look to be others uses besides the one changed here.
I see that `AMQPMessage::createDeliveryCopy` is using it, but probably @clebertsuconic knows about it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] franz1981 commented on pull request #3403: ARTEMIS-3059 AMQP message reencoding should save creating Netty heap arenas
Posted by GitBox <gi...@apache.org>.
franz1981 commented on pull request #3403:
URL: https://github.com/apache/activemq-artemis/pull/3403#issuecomment-757945626
It doesn't seem enough to save Netty heap arenas to be allocated, see
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] franz1981 commented on pull request #3403: ARTEMIS-3059 AMQP message reencoding should save creating Netty heap arenas
Posted by GitBox <gi...@apache.org>.
franz1981 commented on pull request #3403:
URL: https://github.com/apache/activemq-artemis/pull/3403#issuecomment-757925656
@gemmellr and @clebertsuconic need your review here: I see that we have several parts on the broker that are using pooled heap buffers...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org