You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@httpd.apache.org by Yann Ylavic <yl...@gmail.com> on 2015/12/08 16:52:50 UTC

Re: Upgrade when !ap_request_has_body(r) only? (was: for 2.4.18)

On Tue, Dec 8, 2015 at 3:29 PM, William A Rowe Jr <wr...@rowe-clan.net> wrote:
> On Tue, Dec 8, 2015 at 7:37 AM, Yann Ylavic <yl...@apache.org> wrote:
>>
>> E.g. (on top of r1717816):
>
> The problem is that you are disabling *advertising* of the protocol based
> on the content of a request body.  *This* request isn't going to be the
> target
> of the user's advertisement, that applies to their *next* request.  It
> doesn't
> change what I think you meant to change.

Yes, you are right, the real Upgrade is done above, so when we are
here we just prepare the response headers.
Let's think/agree more about how to handle Upgrades in the next release(s).

Regards,
Yann.