[GitHub] [spark] grundprinzip commented on a diff in pull request #39223: [SPARK-41717][CONNECT] Deduplicate print and _repr_html_ at LogicalPlan

[GitBox <gi...@apache.org>]

grundprinzip commented on code in PR #39223:
URL: https://github.com/apache/spark/pull/39223#discussion_r1057437411


##########
python/pyspark/sql/connect/plan.py:
##########
@@ -95,14 +96,68 @@ def to_proto(self, session: "SparkConnectClient", debug: bool = False) -> proto.
 
         return plan
 
-    # TODO(SPARK-41717): Implement the command logic for print and _repr_html_
+    def _parameters_to_print(self, parameters: Mapping[str, Any]) -> Mapping[str, Any]:
+        params = {}

Review Comment:
   The logic of this method is complicated enough to deserve a docstring.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org