You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/01/29 16:38:52 UTC
[GitHub] [druid] leventov opened a new issue #9286: Prohibit assigning
ScheduledExecutorService into ExecutorService
leventov opened a new issue #9286: Prohibit assigning ScheduledExecutorService into ExecutorService
URL: https://github.com/apache/druid/issues/9286
It's needless, a simple ExecutorService should be created instead.
This Structural Search pattern finds two occurrences in the codebase:
```
<searchConfiguration name="Create a simple ExecutorService (not scheduled)" text="$x$ = $y$;" recursive="true" caseInsensitive="true" type="JAVA" pattern_context="default">
<constraint name="__context__" within="" contains="" />
<constraint name="x" nameOfExprType="java\.util\.concurrent\.ExecutorService" expressionTypes="java.util.concurrent.ExecutorService" within="" contains="" />
<constraint name="y" nameOfExprType="java\.util\.concurrent\.ScheduledExecutorService" expressionTypes="java.util.concurrent.ScheduledExecutorService" exprTypeWithinHierarchy="true" within="" contains="" />
</searchConfiguration>
```
Worth experimenting with variable or field declarations, too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson closed issue #9286: Prohibit assigning
ScheduledExecutorService into ExecutorService
Posted by GitBox <gi...@apache.org>.
jihoonson closed issue #9286: Prohibit assigning ScheduledExecutorService into ExecutorService
URL: https://github.com/apache/druid/issues/9286
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] mgill25 commented on issue #9286: Prohibit assigning
ScheduledExecutorService into ExecutorService
Posted by GitBox <gi...@apache.org>.
mgill25 commented on issue #9286: Prohibit assigning ScheduledExecutorService into ExecutorService
URL: https://github.com/apache/druid/issues/9286#issuecomment-582662735
Hi. I'd like to gently start off contributing to Apache druid, and would love to pick up this issue.
If I understand correctly, for the two instances in this search, I should make sure that a regular `ExecutorService` is created for the variables instead of `ScheduledExecutorService`. I suspect there are already concurrency utility functions that help in doing that within the codebase that I can use? I'm not at all familiar with the codebase, so I will appreciate any guidance towards how to go on about fixing these issues.
Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] leventov commented on issue #9286: Prohibit assigning
ScheduledExecutorService into ExecutorService
Posted by GitBox <gi...@apache.org>.
leventov commented on issue #9286: Prohibit assigning ScheduledExecutorService into ExecutorService
URL: https://github.com/apache/druid/issues/9286#issuecomment-582784664
> I suspect there are already concurrency utility functions that help in doing that within the codebase that I can use?
Yes, in `Execs` class
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org