You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "David Smiley (Jira)" <ji...@apache.org> on 2020/03/03 18:23:00 UTC
[jira] [Commented] (LUCENE-8849) DocValuesRewriteMethod.visit
should visit the MTQ
[ https://issues.apache.org/jira/browse/LUCENE-8849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17050458#comment-17050458 ]
David Smiley commented on LUCENE-8849:
--------------------------------------
Thanks for the patch Michele Palmia ! Just curious; was there a use-case that prompted your interest?
> DocValuesRewriteMethod.visit should visit the MTQ
> -------------------------------------------------
>
> Key: LUCENE-8849
> URL: https://issues.apache.org/jira/browse/LUCENE-8849
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/search
> Reporter: David Smiley
> Priority: Minor
> Attachments: LUCENE-8849.patch
>
>
> The DocValuesRewriteMethod implements the QueryVisitor API (visit method) in a way that surprises me. It does not visit the wrapped MTQ query. Shouldn't it? Here is what I think it should do, similar to other query wrappers:
> {code:java}
> @Override
> public void visit(QueryVisitor visitor) {
> query.visit(visitor.getSubVisitor(BooleanClause.Occur.MUST, this));
> }
> {code}
> CC [~romseygeek]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org