You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/10/30 09:03:12 UTC

[GitHub] [calcite] rubenada commented on a change in pull request #1543: [CALCITE-3455] Redundant rule firing for both logical and physical nodes

rubenada commented on a change in pull request #1543: [CALCITE-3455] Redundant rule firing for both logical and physical nodes
URL: https://github.com/apache/calcite/pull/1543#discussion_r340493776
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableLimitRule.java
 ##########
 @@ -30,7 +31,7 @@
 class EnumerableLimitRule extends RelOptRule {
   EnumerableLimitRule() {
     super(
-        operand(Sort.class, any()),
+        operand(LogicalSort.class, any()),
 
 Review comment:
   Please update the javadoc accordingly (`org.apache.calcite.rel.logical.LogicalSort` instead of `org.apache.calcite.rel.core.Sort`). The same for the rest of the modified rules.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services