vendor code drop

[Gary <ga...@wandisco.com>]

Hi,

I was hoping to be able to get away without making changes directly to 
the trac source but I am not a huge fan of monkey patching as it can 
make debugging more confusing. Working directly on a copy of core trac 
will make it easier to ensure that the correct code, and the expected 
code, is run.

We already seem to have a vendor directory so someone was forward 
thinking enough to expect this.. so I'm currently in the process of 
creating a vendor branch of trac (using the advice from 
http://svnbook.red-bean.com/en/1.1/ch07s05.html).

If I understand correctly, I don't think that needs any further 
agreement from Trac as, at worst, we will be able to generate patches 
from the diff between the copy in the vendor directory and our working 
branch.

Cheers,
     Gary

Re: vendor code drop

[Olemis Lang <ol...@gmail.com>]

On Wed, Mar 14, 2012 at 6:28 AM, Gary <ga...@wandisco.com> wrote:
> Hi,
>

:)

> I was hoping to be able to get away without making changes directly to the
> trac source but I am not a huge fan of monkey patching as it can make
> debugging more confusing. Working directly on a copy of core trac will make
> it easier to ensure that the correct code, and the expected code, is run.
>

+1

[...]
>
> If I understand correctly, I don't think that needs any further agreement
> from Trac as, at worst, we will be able to generate patches from the diff
> between the copy in the vendor directory and our working branch.
>

I'm hoping u'll incorporate these patches [1]_ at the right time ;)

.. [1] Patches needed to make Dashboard plugin work
        (https://bitbucket.org/olemis/trac-mq/src/bh_dashboard_bootstrap)

-- 
Regards,

Olemis.