[jira] [Comment Edited] (THRIFT-1977) C# compiler should generate constant files prefixed with thrift file name

["Deniss Afonin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13667648#comment-13667648 ] 

Deniss Afonin edited comment on THRIFT-1977 at 5/27/13 9:13 AM:
----------------------------------------------------------------

There are two issues with v2 patch.

1. When you have const list or map two static constructors will be generated and they will collide in partial Constants class.

2. When constants from different thrift files have same name, they will collide too.

                
      was (Author: afds):
    There are 2 issues with v2 patch.

1. When you have const list or map two static constructors will be generated and they will collide in partial Constants class.

2. When constants from different thrift files have same name, they will collide too.

                  
> C# compiler should generate constant files prefixed with thrift file name
> -------------------------------------------------------------------------
>
>                 Key: THRIFT-1977
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1977
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C# - Compiler
>    Affects Versions: 0.9, 1.0
>            Reporter: Deniss Afonin
>            Priority: Minor
>         Attachments: t_csharp_generator.patch, testcases_v2.zip, Testcases.zip, THRIFT-1977-Csharp_generate_constant_files_prefixed_with_thrift_file_name-v2.patch
>
>
> When you compile (recursively) thrift file that contains constants and includes another thrift file with constants, then only one Constants.cs file will be produced and it won't contain constants from the included file.
> Compiler should behave like a java version, for each thrift file with constants, generate a prefixed constants file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira