You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/08/10 09:25:53 UTC

[GitHub] [incubator-devlake] keon94 opened a new issue, #2134: Add more context to error messages

keon94 opened a new issue, #2134:
URL: https://github.com/apache/incubator-devlake/issues/2134

   ## What and why to refactor
   Many plugin subtasks directly return errors without adding any extra context to the message. This makes troubleshooting difficult. For example, [this](https://github.com/apache/incubator-devlake/blob/0d3aa41e5e3db60e7ddfd3c3835f40e8c1c8eeb4/plugins/github/tasks/pr_commit_extractor.go#L85), which might produce a Json unmarsal error, needs to have a message that additionally tells us something like "unable to get Input while extracting pull request commits".
   
   ## Describe the solution you'd like
   Identify all such plugin subtasks and wrap the error messages with more context.
   
   ## Related issues
   Similar to #1447 
   ## Additional context
   n/a
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] github-actions[bot] commented on issue #2134: Add more context to error messages

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #2134:
URL: https://github.com/apache/incubator-devlake/issues/2134#issuecomment-1192053656

   This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] github-actions[bot] closed issue #2134: Add more context to error messages

Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed issue #2134: Add more context to error messages
URL: https://github.com/apache/incubator-devlake/issues/2134


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] keon94 commented on issue #2134: Add more context to error messages

Posted by GitBox <gi...@apache.org>.
keon94 commented on issue #2134:
URL: https://github.com/apache/incubator-devlake/issues/2134#issuecomment-1160659193

   For example, at every package level (or even function level) wrap the thrown error like this:
   `fmt.Printf("error while doing X: %v")`
   and rethrow this new error.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] keon94 commented on issue #2134: Add more context to error messages

Posted by GitBox <gi...@apache.org>.
keon94 commented on issue #2134:
URL: https://github.com/apache/incubator-devlake/issues/2134#issuecomment-1222362239

   @Startrekzky @klesh As per our conversation in our weekly meeting, I've increased the scope on this issue to make the backend use a more robust error framework with support for user friendly messages, wrapped errors and stacktraces.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] keon94 commented on issue #2134: Add more context to error messages

Posted by GitBox <gi...@apache.org>.
keon94 commented on issue #2134:
URL: https://github.com/apache/incubator-devlake/issues/2134#issuecomment-1215304002

   PR: #2745 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] klesh closed issue #2134: Add more context to error messages

Posted by GitBox <gi...@apache.org>.
klesh closed issue #2134: Add more context to error messages
URL: https://github.com/apache/incubator-devlake/issues/2134


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] yumengwang03 commented on issue #2134: Add more context to error messages

Posted by GitBox <gi...@apache.org>.
yumengwang03 commented on issue #2134:
URL: https://github.com/apache/incubator-devlake/issues/2134#issuecomment-1161459667

   Please be aware that @taninghan has attached the UI design in https://github.com/apache/incubator-devlake/issues/1447


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] github-actions[bot] commented on issue #2134: Add more context to error messages

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #2134:
URL: https://github.com/apache/incubator-devlake/issues/2134#issuecomment-1200045533

   This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org