You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/07/28 21:03:00 UTC
[GitHub] [trafficcontrol] jpappa200 opened a new pull request, #6991: t3c log run mode and log update flag changes
jpappa200 opened a new pull request, #6991:
URL: https://github.com/apache/trafficcontrol/pull/6991
<!--
Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
If this closes or relates to an existing issue, please reference it using one of the following:
Closes: #ISSUE
Related: #ISSUE
If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://apache.org/security regarding vulnerability disclosure.
-->
Right now t3c-apply does not log what mode was run (syncds|badass|revalidate) this will log the run mode. At the end of the t3c-apply run TO is updated to clear the update/revalidate flags. this change logs the current value, what it was updated to, and how log it took to update.
<!-- **^ Add meaningful description above** --><hr/>
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this PR.
Feel free to add the name of a tool or script that is affected but not on the list.
-->
- Traffic Control Cache Config (`t3c`, formerly ORT)
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your PR.
If your PR has tests (and most should), provide the steps needed to run the tests.
If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. -->
Build RPM and install on a cache, queue updates and run t3c-apply in one of the 3 modes listed above. you should see the run mode logged at the beginning and the TO update change at the end of the run
## If this is a bugfix, which Traffic Control versions contained the bug?
<!-- Delete this section if the PR is not a bugfix, or if the bug is only in the master branch.
Examples:
- 5.1.2
- 5.1.3 (RC1)
-->
## PR submission checklist
- [ ] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
- [ ] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. -->
- [ ] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rob05c commented on a diff in pull request #6991: t3c log run mode and log update flag changes
Posted by GitBox <gi...@apache.org>.
rob05c commented on code in PR #6991:
URL: https://github.com/apache/trafficcontrol/pull/6991#discussion_r933637325
##########
cache-config/t3c-apply/torequest/torequest.go:
##########
@@ -1169,17 +1175,25 @@ func (r *TrafficOpsReq) UpdateTrafficOps(syncdsUpdate *UpdateStatus) error {
// TODO: The boolean flags/representation can be removed after ATC (v7.0+)
if !r.Cfg.ReportOnly && !r.Cfg.NoUnsetUpdateFlag {
+ start := time.Now()
+ apply := []string{}
+ var b bool
if r.Cfg.Files == t3cutil.ApplyFilesFlagAll {
- b := false
+ b = false
+ apply = append(apply, "update")
+ log.Infof("Update flag currently set to %v, setting to %v", serverStatus.UpdatePending, b)
err = sendUpdate(r.Cfg, serverStatus.ConfigUpdateTime, nil, &b, nil)
} else if r.Cfg.Files == t3cutil.ApplyFilesFlagReval {
- b := false
+ b = false
+ apply = append(apply, t3cutil.ApplyFilesFlagReval.String())
Review Comment:
This has the text value you want, but this enum is semantically something completely different.
The enum `ApplyFilesFlag` is the CLI flag for whether to apply all config files, or just the regex_revalidate.config file.
Whereas here, the word "reval" is being used to indicate revalidate pending flag in Traffic Ops.
That might confuse someone trying to understand the code in the future. Would you object to changing this to either a literal like update above, `"reval"`, or putting both in their own enum like `const TrafficOpsPendingFlag TrafficOpsPendingFlagReval = "reval"`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rob05c commented on a diff in pull request #6991: t3c log run mode and log update flag changes
Posted by GitBox <gi...@apache.org>.
rob05c commented on code in PR #6991:
URL: https://github.com/apache/trafficcontrol/pull/6991#discussion_r933640574
##########
cache-config/t3c-apply/torequest/torequest.go:
##########
@@ -1169,17 +1175,25 @@ func (r *TrafficOpsReq) UpdateTrafficOps(syncdsUpdate *UpdateStatus) error {
// TODO: The boolean flags/representation can be removed after ATC (v7.0+)
if !r.Cfg.ReportOnly && !r.Cfg.NoUnsetUpdateFlag {
+ start := time.Now()
+ apply := []string{}
+ var b bool
Review Comment:
Another nitpick: the scope of this variable is a bit too long for a single character. Variable name lengths should correspond to their scope.
Single-letter vars are ok for just a couple lines, but for a dozen or so like here, something more descriptive like "updateFlagVal" would be easier to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rob05c commented on a diff in pull request #6991: t3c log run mode and log update flag changes
Posted by GitBox <gi...@apache.org>.
rob05c commented on code in PR #6991:
URL: https://github.com/apache/trafficcontrol/pull/6991#discussion_r933638339
##########
cache-config/t3c-apply/torequest/torequest.go:
##########
@@ -1137,6 +1137,12 @@ func (r *TrafficOpsReq) StartServices(syncdsUpdate *UpdateStatus) error {
return nil
}
+func (r *TrafficOpsReq) ShowUpdateStatus(flagType []string, start time.Time, curSetting, newSetting bool) {
Review Comment:
Nitpick, but it isn't clear from the name what "show" is doing, Usually "show" means displaying something to the user in a graphical UI.
IMO `LogUpdateStatuses` would be clearer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rob05c merged pull request #6991: t3c log run mode and log update flag changes
Posted by GitBox <gi...@apache.org>.
rob05c merged PR #6991:
URL: https://github.com/apache/trafficcontrol/pull/6991
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org