You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/10/29 21:03:46 UTC

[GitHub] [cordova-android] PieterVanPoyer commented on pull request #1113: WIP: Features/webp support for splashscreen

PieterVanPoyer commented on pull request #1113:
URL: https://github.com/apache/cordova-android/pull/1113#issuecomment-719020804


   > Could you also test if .jpg splashscreen do work? It's stated in the docs, but it seems like that there is a hardcoded check to `screen.png`.
   
   @timbru31 Hey I did test the .jpg flow. Really odd, but it works. So what happens, the .jpg is saved as a screen.png in the android project. But android is just displaying it nice. 
   
   A testrepo is available at: https://github.com/PieterVanPoyer/cordova-plugin-splashscreen-testing-app/tree/testing/jpg-splash-screen 
   
   ![image](https://user-images.githubusercontent.com/33040889/97631956-15b80300-1a32-11eb-86f9-cba2bb6c7668.png)
   
   Now this pull is still WIP, because the original screen.png's (of the android template project must be deleted when webp is found. Still figuring out were to delete them.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org