[GitHub] [spark] srowen commented on a change in pull request #25251: [MINOR] Trivial cleanups

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #25251: [MINOR] Trivial cleanups
URL: https://github.com/apache/spark/pull/25251#discussion_r307396339
 
 

 ##########
 File path: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeMapData.java
 ##########
 @@ -143,7 +143,7 @@ public void writeExternal(ObjectOutput out) throws IOException {
   }
 
   @Override
-  public void readExternal(ObjectInput in) throws IOException, ClassNotFoundException {
+  public void readExternal(ObjectInput in) throws IOException {
 
 Review comment:
   I think this OK but I have this recollection in the back of my mind that it's a special serialization method that needs this particular signature. I think I'm thinking of the `Serializable` mechanism's requirements. Probably fine to remove this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org