[GitHub] [skywalking] wu-sheng edited a comment on issue #4166: Support Browser protocol at OAP

[GitBox <gi...@apache.org>]

wu-sheng edited a comment on issue #4166: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/issues/4166#issuecomment-570451129
 
 
   OK, I just assign this to you. Several keys. 
   1. A new receiver module is required.
   1. Register for the endpoint(pagePath) is the first priority work.
   1. The browser-related sources should be new and separated too all related sources. OAL and antlr should be changed too.
   1. All sources should be designed and discussed first.
   
   ### Metrics are following
   1. PV for every page(endpoint), version(instance) and service
   1. The error rate for every page.
   1. TopN page is automatically available by topN query, don't need to implement
   1. Error logs for every `BrowserErrorLog`, with rate sampling.
   1. Avg value of all fields in PerfDetail.
   
   ~~To @Fine0830, a question, what metrics are required for all fields in PerfDetail. Avg time? Maybe.~~
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services