You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/16 09:13:45 UTC

[GitHub] [spark] beliefer edited a comment on pull request #35269: [SPARK-28516][SQL] Data Type Formatting Functions: `to_char`

beliefer edited a comment on pull request #35269:
URL: https://github.com/apache/spark/pull/35269#issuecomment-1068878512


   > What is the desired semantic if the format does not cover the domain of the number?
   SELECT to_char(111, '9'), to_char(1.5, '9');
   Oracle output:
   '##' and ' 2'
   PgSQL output:
   ' #' and ' 2'
   I think the implement of this PR should return '#' based on the length of input format or throw errors.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org