You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/26 15:09:57 UTC
[GitHub] [flink] pnowojski opened a new pull request #17572: [FLINK-23647][checkpointing] Wait for CheckpointsCleaner to complete before closing cluster
pnowojski opened a new pull request #17572:
URL: https://github.com/apache/flink/pull/17572
This change should prevent errors in tests that are checking for existence of checkpoint files. Before this change, checkpoint files could have disappeared after job submitted via mini cluster has already finished/closed, which was leading to some unexpected test failures.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (**yes** / no / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17572: [FLINK-23647][checkpointing] Wait for CheckpointsCleaner to complete before closing cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17572:
URL: https://github.com/apache/flink/pull/17572#issuecomment-952040222
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475",
"triggerID" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"triggerType" : "PUSH"
}, {
"hash" : "2e33c87239fdd6a082ed3ae41a4e2c49c5e92031",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25478",
"triggerID" : "2e33c87239fdd6a082ed3ae41a4e2c49c5e92031",
"triggerType" : "PUSH"
}, {
"hash" : "b21beb6ac7b33b77b37f1d89dcd1d5a2f8999963",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25570",
"triggerID" : "b21beb6ac7b33b77b37f1d89dcd1d5a2f8999963",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b21beb6ac7b33b77b37f1d89dcd1d5a2f8999963 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25570)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17572: [FLINK-23647][checkpointing] Wait for CheckpointsCleaner to complete before closing cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17572:
URL: https://github.com/apache/flink/pull/17572#issuecomment-952040222
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475",
"triggerID" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"triggerType" : "PUSH"
}, {
"hash" : "2e33c87239fdd6a082ed3ae41a4e2c49c5e92031",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2e33c87239fdd6a082ed3ae41a4e2c49c5e92031",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c20827f354a6f033d0ccfd71d353f9e5f6669c7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475)
* 2e33c87239fdd6a082ed3ae41a4e2c49c5e92031 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17572: [FLINK-23647][checkpointing] Wait for CheckpointsCleaner to complete before closing cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17572:
URL: https://github.com/apache/flink/pull/17572#issuecomment-952040222
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475",
"triggerID" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c20827f354a6f033d0ccfd71d353f9e5f6669c7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17572: [FLINK-23647][checkpointing] Wait for CheckpointsCleaner to complete before closing cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17572:
URL: https://github.com/apache/flink/pull/17572#issuecomment-952040222
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475",
"triggerID" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"triggerType" : "PUSH"
}, {
"hash" : "2e33c87239fdd6a082ed3ae41a4e2c49c5e92031",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25478",
"triggerID" : "2e33c87239fdd6a082ed3ae41a4e2c49c5e92031",
"triggerType" : "PUSH"
}, {
"hash" : "b21beb6ac7b33b77b37f1d89dcd1d5a2f8999963",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25570",
"triggerID" : "b21beb6ac7b33b77b37f1d89dcd1d5a2f8999963",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2e33c87239fdd6a082ed3ae41a4e2c49c5e92031 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25478)
* b21beb6ac7b33b77b37f1d89dcd1d5a2f8999963 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25570)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #17572: [FLINK-23647][checkpointing] Wait for CheckpointsCleaner to complete before closing cluster
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #17572:
URL: https://github.com/apache/flink/pull/17572#discussion_r738225093
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointsCleaner.java
##########
@@ -89,9 +95,34 @@ private void cleanup(
checkpoint.getCheckpointID(),
e);
} finally {
- numberOfCheckpointsToClean.decrementAndGet();
+ decrementNumberOfCheckpointsToClean();
postCleanupAction.run();
}
});
}
+
+ private synchronized void decrementNumberOfCheckpointsToClean() {
+ numberOfCheckpointsToClean--;
+ maybeCompleteCloseUnsafe();
+ }
+
+ private void maybeCompleteCloseUnsafe() {
+ if (numberOfCheckpointsToClean == 0 && cleanUpFuture != null) {
+ cleanUpFuture.complete(null);
+ }
+ }
+
+ private synchronized void incrementNumberOfCheckpointsToClean() {
+ checkState(cleanUpFuture == null, "CheckpointsCleaner has already been closed");
+ numberOfCheckpointsToClean++;
+ }
+
+ @Override
+ public synchronized CompletableFuture<Void> closeAsync() {
Review comment:
After an offline discussion we agreed that keeping `Closeable` is probably slightly better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17572: [FLINK-23647][checkpointing] Wait for CheckpointsCleaner to complete before closing cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17572:
URL: https://github.com/apache/flink/pull/17572#issuecomment-952040222
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475",
"triggerID" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"triggerType" : "PUSH"
}, {
"hash" : "2e33c87239fdd6a082ed3ae41a4e2c49c5e92031",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2e33c87239fdd6a082ed3ae41a4e2c49c5e92031",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c20827f354a6f033d0ccfd71d353f9e5f6669c7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475)
* 2e33c87239fdd6a082ed3ae41a4e2c49c5e92031 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17572: [FLINK-23647][checkpointing] Wait for CheckpointsCleaner to complete before closing cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17572:
URL: https://github.com/apache/flink/pull/17572#issuecomment-952040222
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475",
"triggerID" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c20827f354a6f033d0ccfd71d353f9e5f6669c7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17572: [FLINK-23647][checkpointing] Wait for CheckpointsCleaner to complete before closing cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17572:
URL: https://github.com/apache/flink/pull/17572#issuecomment-952040222
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475",
"triggerID" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c20827f354a6f033d0ccfd71d353f9e5f6669c7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17572: [FLINK-23647][checkpointing] Wait for CheckpointsCleaner to complete before closing cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17572:
URL: https://github.com/apache/flink/pull/17572#issuecomment-952040222
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475",
"triggerID" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"triggerType" : "PUSH"
}, {
"hash" : "2e33c87239fdd6a082ed3ae41a4e2c49c5e92031",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2e33c87239fdd6a082ed3ae41a4e2c49c5e92031",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c20827f354a6f033d0ccfd71d353f9e5f6669c7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475)
* 2e33c87239fdd6a082ed3ae41a4e2c49c5e92031 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17572: [FLINK-23647][checkpointing] Wait for CheckpointsCleaner to complete before closing cluster
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17572:
URL: https://github.com/apache/flink/pull/17572#issuecomment-952040222
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c20827f354a6f033d0ccfd71d353f9e5f6669c7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17572: [FLINK-23647][checkpointing] Wait for CheckpointsCleaner to complete before closing cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17572:
URL: https://github.com/apache/flink/pull/17572#issuecomment-952040222
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475",
"triggerID" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"triggerType" : "PUSH"
}, {
"hash" : "2e33c87239fdd6a082ed3ae41a4e2c49c5e92031",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25478",
"triggerID" : "2e33c87239fdd6a082ed3ae41a4e2c49c5e92031",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c20827f354a6f033d0ccfd71d353f9e5f6669c7 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475)
* 2e33c87239fdd6a082ed3ae41a4e2c49c5e92031 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25478)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17572: [FLINK-23647][checkpointing] Wait for CheckpointsCleaner to complete before closing cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17572:
URL: https://github.com/apache/flink/pull/17572#issuecomment-952040222
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475",
"triggerID" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c20827f354a6f033d0ccfd71d353f9e5f6669c7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #17572: [FLINK-23647][checkpointing] Wait for CheckpointsCleaner to complete before closing cluster
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #17572:
URL: https://github.com/apache/flink/pull/17572#discussion_r737238906
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointsCleaner.java
##########
@@ -89,9 +95,34 @@ private void cleanup(
checkpoint.getCheckpointID(),
e);
} finally {
- numberOfCheckpointsToClean.decrementAndGet();
+ decrementNumberOfCheckpointsToClean();
postCleanupAction.run();
}
});
}
+
+ private synchronized void decrementNumberOfCheckpointsToClean() {
+ numberOfCheckpointsToClean--;
+ maybeCompleteCloseUnsafe();
+ }
+
+ private void maybeCompleteCloseUnsafe() {
+ if (numberOfCheckpointsToClean == 0 && cleanUpFuture != null) {
+ cleanUpFuture.complete(null);
+ }
+ }
+
+ private synchronized void incrementNumberOfCheckpointsToClean() {
+ checkState(cleanUpFuture == null, "CheckpointsCleaner has already been closed");
+ numberOfCheckpointsToClean++;
+ }
+
+ @Override
+ public synchronized CompletableFuture<Void> closeAsync() {
+ if (cleanUpFuture == null) {
+ cleanUpFuture = new CompletableFuture<>();
Review comment:
It seems a bit sketchy for the Scheduler to wait for the cleanup although it hasn't directly initiated it. Who kicks of the actual cleanup? Is it the CheckpointCoordinator? In that case, why don't we have the coordinator shutdown wait for the cleanup?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #17572: [FLINK-23647][checkpointing] Wait for CheckpointsCleaner to complete before closing cluster
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #17572:
URL: https://github.com/apache/flink/pull/17572#discussion_r737238906
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointsCleaner.java
##########
@@ -89,9 +95,34 @@ private void cleanup(
checkpoint.getCheckpointID(),
e);
} finally {
- numberOfCheckpointsToClean.decrementAndGet();
+ decrementNumberOfCheckpointsToClean();
postCleanupAction.run();
}
});
}
+
+ private synchronized void decrementNumberOfCheckpointsToClean() {
+ numberOfCheckpointsToClean--;
+ maybeCompleteCloseUnsafe();
+ }
+
+ private void maybeCompleteCloseUnsafe() {
+ if (numberOfCheckpointsToClean == 0 && cleanUpFuture != null) {
+ cleanUpFuture.complete(null);
+ }
+ }
+
+ private synchronized void incrementNumberOfCheckpointsToClean() {
+ checkState(cleanUpFuture == null, "CheckpointsCleaner has already been closed");
+ numberOfCheckpointsToClean++;
+ }
+
+ @Override
+ public synchronized CompletableFuture<Void> closeAsync() {
+ if (cleanUpFuture == null) {
+ cleanUpFuture = new CompletableFuture<>();
Review comment:
It seems a bit sketchy for the Dispatcher to wait for the cleanup although it hasn't directly initiated it. Who kicks of the actual cleanup? Is it the CheckpointCoordinator? In that case, why don't we have the coordinator shutdown wait for the cleanup?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointsCleaner.java
##########
@@ -89,9 +95,34 @@ private void cleanup(
checkpoint.getCheckpointID(),
e);
} finally {
- numberOfCheckpointsToClean.decrementAndGet();
+ decrementNumberOfCheckpointsToClean();
postCleanupAction.run();
}
});
}
+
+ private synchronized void decrementNumberOfCheckpointsToClean() {
+ numberOfCheckpointsToClean--;
+ maybeCompleteCloseUnsafe();
+ }
+
+ private void maybeCompleteCloseUnsafe() {
+ if (numberOfCheckpointsToClean == 0 && cleanUpFuture != null) {
+ cleanUpFuture.complete(null);
+ }
+ }
+
+ private synchronized void incrementNumberOfCheckpointsToClean() {
+ checkState(cleanUpFuture == null, "CheckpointsCleaner has already been closed");
+ numberOfCheckpointsToClean++;
+ }
+
+ @Override
+ public synchronized CompletableFuture<Void> closeAsync() {
Review comment:
Using Closeable is misleading because I would expect this call to initiate the closing, not just wait for some other component to trigger it in the background.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17572: [FLINK-23647][checkpointing] Wait for CheckpointsCleaner to complete before closing cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17572:
URL: https://github.com/apache/flink/pull/17572#issuecomment-952040222
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475",
"triggerID" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c20827f354a6f033d0ccfd71d353f9e5f6669c7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on pull request #17572: [FLINK-23647][checkpointing] Wait for CheckpointsCleaner to complete before closing cluster
Posted by GitBox <gi...@apache.org>.
pnowojski commented on pull request #17572:
URL: https://github.com/apache/flink/pull/17572#issuecomment-952628719
Test failure is unrelated https://issues.apache.org/jira/browse/FLINK-24662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski merged pull request #17572: [FLINK-23647][checkpointing] Wait for CheckpointsCleaner to complete before closing cluster
Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #17572:
URL: https://github.com/apache/flink/pull/17572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17572: [FLINK-23647][checkpointing] Wait for CheckpointsCleaner to complete before closing cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17572:
URL: https://github.com/apache/flink/pull/17572#issuecomment-952040222
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475",
"triggerID" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c20827f354a6f033d0ccfd71d353f9e5f6669c7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17572: [FLINK-23647][checkpointing] Wait for CheckpointsCleaner to complete before closing cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17572:
URL: https://github.com/apache/flink/pull/17572#issuecomment-952040222
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475",
"triggerID" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"triggerType" : "PUSH"
}, {
"hash" : "2e33c87239fdd6a082ed3ae41a4e2c49c5e92031",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2e33c87239fdd6a082ed3ae41a4e2c49c5e92031",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c20827f354a6f033d0ccfd71d353f9e5f6669c7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475)
* 2e33c87239fdd6a082ed3ae41a4e2c49c5e92031 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17572: [FLINK-23647][checkpointing] Wait for CheckpointsCleaner to complete before closing cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17572:
URL: https://github.com/apache/flink/pull/17572#issuecomment-952040222
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475",
"triggerID" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"triggerType" : "PUSH"
}, {
"hash" : "2e33c87239fdd6a082ed3ae41a4e2c49c5e92031",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2e33c87239fdd6a082ed3ae41a4e2c49c5e92031",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c20827f354a6f033d0ccfd71d353f9e5f6669c7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475)
* 2e33c87239fdd6a082ed3ae41a4e2c49c5e92031 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17572: [FLINK-23647][checkpointing] Wait for CheckpointsCleaner to complete before closing cluster
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17572:
URL: https://github.com/apache/flink/pull/17572#issuecomment-952041445
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 5c20827f354a6f033d0ccfd71d353f9e5f6669c7 (Tue Oct 26 15:13:41 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17572: [FLINK-23647][checkpointing] Wait for CheckpointsCleaner to complete before closing cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17572:
URL: https://github.com/apache/flink/pull/17572#issuecomment-952040222
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475",
"triggerID" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"triggerType" : "PUSH"
}, {
"hash" : "2e33c87239fdd6a082ed3ae41a4e2c49c5e92031",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25478",
"triggerID" : "2e33c87239fdd6a082ed3ae41a4e2c49c5e92031",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c20827f354a6f033d0ccfd71d353f9e5f6669c7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475)
* 2e33c87239fdd6a082ed3ae41a4e2c49c5e92031 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25478)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17572: [FLINK-23647][checkpointing] Wait for CheckpointsCleaner to complete before closing cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17572:
URL: https://github.com/apache/flink/pull/17572#issuecomment-952040222
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475",
"triggerID" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c20827f354a6f033d0ccfd71d353f9e5f6669c7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #17572: [FLINK-23647][checkpointing] Wait for CheckpointsCleaner to complete before closing cluster
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #17572:
URL: https://github.com/apache/flink/pull/17572#discussion_r738199426
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointsCleaner.java
##########
@@ -89,9 +95,34 @@ private void cleanup(
checkpoint.getCheckpointID(),
e);
} finally {
- numberOfCheckpointsToClean.decrementAndGet();
+ decrementNumberOfCheckpointsToClean();
postCleanupAction.run();
}
});
}
+
+ private synchronized void decrementNumberOfCheckpointsToClean() {
+ numberOfCheckpointsToClean--;
+ maybeCompleteCloseUnsafe();
+ }
+
+ private void maybeCompleteCloseUnsafe() {
+ if (numberOfCheckpointsToClean == 0 && cleanUpFuture != null) {
+ cleanUpFuture.complete(null);
+ }
+ }
+
+ private synchronized void incrementNumberOfCheckpointsToClean() {
Review comment:
nit: put this above `decrement*`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17572: [FLINK-23647][checkpointing] Wait for CheckpointsCleaner to complete before closing cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17572:
URL: https://github.com/apache/flink/pull/17572#issuecomment-952040222
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475",
"triggerID" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"triggerType" : "PUSH"
}, {
"hash" : "2e33c87239fdd6a082ed3ae41a4e2c49c5e92031",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2e33c87239fdd6a082ed3ae41a4e2c49c5e92031",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c20827f354a6f033d0ccfd71d353f9e5f6669c7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475)
* 2e33c87239fdd6a082ed3ae41a4e2c49c5e92031 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on pull request #17572: [FLINK-23647][checkpointing] Wait for CheckpointsCleaner to complete before closing cluster
Posted by GitBox <gi...@apache.org>.
pnowojski commented on pull request #17572:
URL: https://github.com/apache/flink/pull/17572#issuecomment-953869309
Thanks for the review @zentol. Azure is green merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #17572: [FLINK-23647][checkpointing] Wait for CheckpointsCleaner to complete before closing cluster
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #17572:
URL: https://github.com/apache/flink/pull/17572#discussion_r738225561
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointsCleaner.java
##########
@@ -89,9 +95,34 @@ private void cleanup(
checkpoint.getCheckpointID(),
e);
} finally {
- numberOfCheckpointsToClean.decrementAndGet();
+ decrementNumberOfCheckpointsToClean();
postCleanupAction.run();
}
});
}
+
+ private synchronized void decrementNumberOfCheckpointsToClean() {
+ numberOfCheckpointsToClean--;
+ maybeCompleteCloseUnsafe();
+ }
+
+ private void maybeCompleteCloseUnsafe() {
+ if (numberOfCheckpointsToClean == 0 && cleanUpFuture != null) {
+ cleanUpFuture.complete(null);
+ }
+ }
+
+ private synchronized void incrementNumberOfCheckpointsToClean() {
+ checkState(cleanUpFuture == null, "CheckpointsCleaner has already been closed");
+ numberOfCheckpointsToClean++;
+ }
+
+ @Override
+ public synchronized CompletableFuture<Void> closeAsync() {
+ if (cleanUpFuture == null) {
+ cleanUpFuture = new CompletableFuture<>();
Review comment:
After an offline discussion we agreed that this proposal is fine, while alternative would be more complicated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17572: [FLINK-23647][checkpointing] Wait for CheckpointsCleaner to complete before closing cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17572:
URL: https://github.com/apache/flink/pull/17572#issuecomment-952040222
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475",
"triggerID" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"triggerType" : "PUSH"
}, {
"hash" : "2e33c87239fdd6a082ed3ae41a4e2c49c5e92031",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25478",
"triggerID" : "2e33c87239fdd6a082ed3ae41a4e2c49c5e92031",
"triggerType" : "PUSH"
}, {
"hash" : "b21beb6ac7b33b77b37f1d89dcd1d5a2f8999963",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b21beb6ac7b33b77b37f1d89dcd1d5a2f8999963",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2e33c87239fdd6a082ed3ae41a4e2c49c5e92031 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25478)
* b21beb6ac7b33b77b37f1d89dcd1d5a2f8999963 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17572: [FLINK-23647][checkpointing] Wait for CheckpointsCleaner to complete before closing cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17572:
URL: https://github.com/apache/flink/pull/17572#issuecomment-952040222
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475",
"triggerID" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"triggerType" : "PUSH"
}, {
"hash" : "2e33c87239fdd6a082ed3ae41a4e2c49c5e92031",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2e33c87239fdd6a082ed3ae41a4e2c49c5e92031",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c20827f354a6f033d0ccfd71d353f9e5f6669c7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475)
* 2e33c87239fdd6a082ed3ae41a4e2c49c5e92031 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17572: [FLINK-23647][checkpointing] Wait for CheckpointsCleaner to complete before closing cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17572:
URL: https://github.com/apache/flink/pull/17572#issuecomment-952040222
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475",
"triggerID" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"triggerType" : "PUSH"
}, {
"hash" : "2e33c87239fdd6a082ed3ae41a4e2c49c5e92031",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2e33c87239fdd6a082ed3ae41a4e2c49c5e92031",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c20827f354a6f033d0ccfd71d353f9e5f6669c7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475)
* 2e33c87239fdd6a082ed3ae41a4e2c49c5e92031 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17572: [FLINK-23647][checkpointing] Wait for CheckpointsCleaner to complete before closing cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17572:
URL: https://github.com/apache/flink/pull/17572#issuecomment-952040222
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475",
"triggerID" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"triggerType" : "PUSH"
}, {
"hash" : "2e33c87239fdd6a082ed3ae41a4e2c49c5e92031",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25478",
"triggerID" : "2e33c87239fdd6a082ed3ae41a4e2c49c5e92031",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2e33c87239fdd6a082ed3ae41a4e2c49c5e92031 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25478)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17572: [FLINK-23647][checkpointing] Wait for CheckpointsCleaner to complete before closing cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17572:
URL: https://github.com/apache/flink/pull/17572#issuecomment-952040222
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475",
"triggerID" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c20827f354a6f033d0ccfd71d353f9e5f6669c7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17572: [FLINK-23647][checkpointing] Wait for CheckpointsCleaner to complete before closing cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17572:
URL: https://github.com/apache/flink/pull/17572#issuecomment-952040222
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475",
"triggerID" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c20827f354a6f033d0ccfd71d353f9e5f6669c7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17572: [FLINK-23647][checkpointing] Wait for CheckpointsCleaner to complete before closing cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17572:
URL: https://github.com/apache/flink/pull/17572#issuecomment-952040222
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475",
"triggerID" : "5c20827f354a6f033d0ccfd71d353f9e5f6669c7",
"triggerType" : "PUSH"
}, {
"hash" : "2e33c87239fdd6a082ed3ae41a4e2c49c5e92031",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2e33c87239fdd6a082ed3ae41a4e2c49c5e92031",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c20827f354a6f033d0ccfd71d353f9e5f6669c7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25475)
* 2e33c87239fdd6a082ed3ae41a4e2c49c5e92031 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org