Re: Please commit patch in OPENEJB-624 -- Thanks Karan!

[David Blevins <da...@visi.com>]

All committed!

I swear, the idea sounded neat, but looking at it in the code it's  
just that much better.  More comments on the thread where you  
proposed the idea.

FYI, perfect sized change, very easy to review.  I'm not always so  
great with my commits, but this is definitely the way to go.

-David


On Aug 5, 2007, at 11:11 AM, Karan Malhi wrote:

> Anybody wants to take out some time to commit this patch. It won't
> take too much time to review it as all I have done is extracted Logger
> Categories to an interface and replaced existing instances of
> hard-coded Logger Categories with references to constants defined in
> the LogCategory interface.
>
> I was hoping if somebody could apply the patch, then I can start
> working on cleaning up some logging messages, i.e. start putting them
> in properties files.
>
> On 8/5/07, Karan Malhi <ka...@gmail.com> wrote:
>> Could somebody please commit the patch in OPENEJB-624 ?
>>
>> Thanks
>>
>> --
>> Karan Singh Malhi
>>
>
>
> -- 
> Karan Singh Malhi
>

Re: Please commit patch in OPENEJB-624 -- Thanks Karan!

[Karan Malhi <ka...@gmail.com>]

Thanks David,

I did not know what to write in the javadocs for each Logger Category.
If we can write the javadocs, then using the confluence snippet plugin
is a real neat thing. In fact, if we do it once (and I get to know how
it was done), then we can identify some more areas of code which could
be candidates for the snippet plugin. I think this is the fastest  way
to generate user docs (where examples are required).

Also, if you can review the Logger Categories, that would be nice.
Some categories do not start with OpenEJB, and I was not sure about
the reason behind it.

One more thing i realized after refactoring this stuff is how easy it
is now to configure log4j. We just have to look into the LogCategory
interface and then make sure that the default.logging.conf is not
missing any Logger Category (which it is right now, but can now be
easily fixed). No need to search through code any more . :)

On 8/5/07, David Blevins <da...@visi.com> wrote:
> All committed!
>
> I swear, the idea sounded neat, but looking at it in the code it's
> just that much better.  More comments on the thread where you
> proposed the idea.
>
> FYI, perfect sized change, very easy to review.  I'm not always so
> great with my commits, but this is definitely the way to go.
>
> -David
>
>
> On Aug 5, 2007, at 11:11 AM, Karan Malhi wrote:
>
> > Anybody wants to take out some time to commit this patch. It won't
> > take too much time to review it as all I have done is extracted Logger
> > Categories to an interface and replaced existing instances of
> > hard-coded Logger Categories with references to constants defined in
> > the LogCategory interface.
> >
> > I was hoping if somebody could apply the patch, then I can start
> > working on cleaning up some logging messages, i.e. start putting them
> > in properties files.
> >
> > On 8/5/07, Karan Malhi <ka...@gmail.com> wrote:
> >> Could somebody please commit the patch in OPENEJB-624 ?
> >>
> >> Thanks
> >>
> >> --
> >> Karan Singh Malhi
> >>
> >
> >
> > --
> > Karan Singh Malhi
> >
>
>


-- 
Karan Singh Malhi