You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/11/06 13:03:38 UTC
[GitHub] [dubbo-go-pixiu] nicktming opened a new pull request, #518: Feat http dubbo triple
nicktming opened a new pull request, #518:
URL: https://github.com/apache/dubbo-go-pixiu/pull/518
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
fill body, query, uri value to http -> dubbo (triple)
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter commented on pull request #518: Feat http dubbo triple
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #518:
URL: https://github.com/apache/dubbo-go-pixiu/pull/518#issuecomment-1304799940
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/518?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#518](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/518?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (14e9bb0) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/8dc4bd6f9635124388a8b71da8ed4b143afaab9e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8dc4bd6) will **decrease** coverage by `0.03%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## develop #518 +/- ##
===========================================
- Coverage 54.70% 54.67% -0.04%
===========================================
Files 666 666
Lines 77864 77884 +20
===========================================
- Hits 42596 42583 -13
- Misses 31631 31660 +29
- Partials 3637 3641 +4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/518?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pixiu/pkg/client/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/518/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGl4aXUvcGtnL2NsaWVudC9tYXBwZXIuZ28=) | `41.46% <0.00%> (-39.49%)` | :arrow_down: |
| [pkg/kube/inject/watcher.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/518/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvaW5qZWN0L3dhdGNoZXIuZ28=) | `48.14% <0.00%> (-8.65%)` | :arrow_down: |
| [pkg/kube/controllers/queue.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/518/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvY29udHJvbGxlcnMvcXVldWUuZ28=) | `55.22% <0.00%> (-7.47%)` | :arrow_down: |
| [pilot/pkg/model/addressmap.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/518/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlsb3QvcGtnL21vZGVsL2FkZHJlc3NtYXAuZ28=) | `63.23% <0.00%> (-4.42%)` | :arrow_down: |
| [security/pkg/nodeagent/sds/sdsservice.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/518/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VjdXJpdHkvcGtnL25vZGVhZ2VudC9zZHMvc2Rzc2VydmljZS5nbw==) | `84.76% <0.00%> (-2.65%)` | :arrow_down: |
| [security/pkg/nodeagent/cache/secretcache.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/518/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VjdXJpdHkvcGtnL25vZGVhZ2VudC9jYWNoZS9zZWNyZXRjYWNoZS5nbw==) | `84.94% <0.00%> (-0.77%)` | :arrow_down: |
| [...g/serviceregistry/kube/controller/endpointslice.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/518/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlsb3QvcGtnL3NlcnZpY2VyZWdpc3RyeS9rdWJlL2NvbnRyb2xsZXIvZW5kcG9pbnRzbGljZS5nbw==) | `73.44% <0.00%> (-0.69%)` | :arrow_down: |
| [pkg/istio-agent/xds\_proxy\_delta.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/518/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2lzdGlvLWFnZW50L3hkc19wcm94eV9kZWx0YS5nbw==) | `51.29% <0.00%> (-0.52%)` | :arrow_down: |
| [pilot/pkg/bootstrap/certcontroller.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/518/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlsb3QvcGtnL2Jvb3RzdHJhcC9jZXJ0Y29udHJvbGxlci5nbw==) | `42.51% <0.00%> (ø)` | |
| [.../pkg/serviceregistry/kube/controller/controller.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/518/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlsb3QvcGtnL3NlcnZpY2VyZWdpc3RyeS9rdWJlL2NvbnRyb2xsZXIvY29udHJvbGxlci5nbw==) | `72.68% <0.00%> (+0.15%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/518/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] nicktming commented on pull request #518: Feat http dubbo triple
Posted by GitBox <gi...@apache.org>.
nicktming commented on PR #518:
URL: https://github.com/apache/dubbo-go-pixiu/pull/518#issuecomment-1304814877
https://cloud.google.com/endpoints/docs/grpc/transcoding
参考这个协议, 后续准备把这个搞成自动的 (到时再提pr) 用户在proto里面写http 相关的东西就可以了
现在的问题
- 动态的adapter 路径格式写得太死了 很难满足场景要求
- 静态配置维护也比较麻烦
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] nicktming commented on pull request #518: Feat http dubbo triple
Posted by GitBox <gi...@apache.org>.
nicktming commented on PR #518:
URL: https://github.com/apache/dubbo-go-pixiu/pull/518#issuecomment-1304814682
当用户在proto里面自定义http 路径 我理解这部分dubbo-pixiu应该可以主动识别并动态加载以及实现从http->dubbo的转换 可以参考https://zhuanlan.zhihu.com/p/543669815 https://github.com/zeromicro/go-zero 参考这个网关项目 http -> grpc
因为目前 http -> dubbo (triple协议) 还只识别 body; 这样就没法支持GET请求
我加的这部分是 http -> dubbo (triple) 可以识别 uri, queryString, body, 这样可以支持基本的增删改查请求(GET|PUT|POST|DELETE已测);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks commented on a diff in pull request #518: Feat http dubbo triple
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on code in PR #518:
URL: https://github.com/apache/dubbo-go-pixiu/pull/518#discussion_r1025989656
##########
pixiu/pkg/client/mapper.go:
##########
@@ -72,3 +73,33 @@ func GetMapValue(sourceMap map[string]interface{}, keys []string) (interface{},
}
return GetMapValue(deeperStruct, keys[1:])
}
+
+func SetMapValue(sourceMap map[string]interface{}, keys []string, val interface{}, prefix string) error {
Review Comment:
add comment for this func, pls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] mark4z closed pull request #518: Feat http dubbo triple
Posted by GitBox <gi...@apache.org>.
mark4z closed pull request #518: Feat http dubbo triple
URL: https://github.com/apache/dubbo-go-pixiu/pull/518
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org